Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PythonScriptV0] Migrated to Node10 #14150

Merged
merged 4 commits into from
Jan 11, 2021
Merged

[PythonScriptV0] Migrated to Node10 #14150

merged 4 commits into from
Jan 11, 2021

Conversation

DaniilShmelev
Copy link
Contributor

Task name: PythonScript

Description:

  • Updated dependencies
  • Updated uuid v4 import
  • Fixed Mocha types in tests
  • Bumped task version
  • Changed execution handler to Node10

Documentation changes required: No

Added unit tests: No

Attached related issue: https://github.com/microsoft/build-task-team/issues/359

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

Successful pipeline
Node 6 hotfixes branch

@DaniilShmelev DaniilShmelev requested a review from a team December 30, 2020 09:26
egor-bryzgalov
egor-bryzgalov approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@egor-bryzgalov egor-bryzgalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@DaniilShmelev DaniilShmelev merged commit 28a6004 into master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egor-bryzgalov egor-bryzgalov egor-bryzgalov approved these changes

@EzzhevNikita EzzhevNikita EzzhevNikita approved these changes

@anatolybolshakov anatolybolshakov anatolybolshakov approved these changes

@leantk leantk Awaiting requested review from leantk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaniilShmelev @anatolybolshakov @EzzhevNikita @egor-bryzgalov