Node6hotfixes/azure file copy #14147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
This reverts commit 409f46b.
This reverts commit 7056479.
…n-npm-packages" This reverts commit 631fa44.
* Updated the dependencies in package.json * Bumping up the minor version.
* Updated the dependencies in package.json * Bumping up the minor version.
* Updated the dependencies in package.json * Bumping up the minor version.
arjgupta
requested changes
Dec 30, 2020
| @@ -1,12 +1,15 @@ | |||
| { | |||
| "name": "AzureFileCopyV2", | |||
| "dependencies": { | |||
| "@types/mocha": "2.2.48", | |||
| "@types/node": "6.0.68", | |||
| "@types/mocha": "^5.2.7", | |||
There was a problem hiding this comment.
You should stick to a specific version. for all the packages.
| "@types/q": "1.0.7", | ||
| "azure-pipelines-tasks-azure-arm-rest-v2": "1.0.4", | ||
| "azure-pipelines-task-lib": "2.8.0", | ||
| "azure-pipelines-task-lib": "3.0.6-preview.0", |
There was a problem hiding this comment.
is there a stable version of this library that we can use ? Or do we have to use this version ?
There was a problem hiding this comment.
@arjgupta Hi! This is the version prepared for Node 10 migration.
arjgupta
approved these changes
Dec 30, 2020
Tasks/AzureFileCopyV2/task.json
Outdated
| @@ -13,7 +13,7 @@ | |||
| "author": "Microsoft Corporation", | |||
| "version": { | |||
| "Major": 2, | |||
| "Minor": 178, | |||
| "Minor": 179, | |||
There was a problem hiding this comment.
Could you please bump the version in accordance with the current sprint as per this guide for all tasks changed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: AzureFileCopy V2, V3 and V4
Description:
Testing
Windows Agent
AzureFileCopyV2
AzureFileCopyV3
AzureFileCopyV4
Documentation changes required: (Y/N)
Added unit tests: (Y/N)
Attached related issue: (Y/N)
Checklist: