Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UsePythonVersionV0] Migrated to Node10. #14144

Merged
merged 10 commits into from
Feb 19, 2021
Merged

[UsePythonVersionV0] Migrated to Node10. #14144

merged 10 commits into from
Feb 19, 2021

Conversation

egor-bryzgalov
Copy link
Member

@egor-bryzgalov egor-bryzgalov commented Dec 28, 2020 •
edited
Loading

Task name: UsePythonVersionV0

Description: Migrated UsePythonVersionV0 to Node 10.

Removed strict property from tsconfig.json for consistency. It allowed us to avoid unnecessary types casting.

Documentation changes required: No

Added unit tests: No

Attached related issue: #360

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@egor-bryzgalov egor-bryzgalov requested a review from a team December 28, 2020 13:40
@egor-bryzgalov egor-bryzgalov self-assigned this Dec 28, 2020
@egor-bryzgalov egor-bryzgalov requested a review from a team December 28, 2020 14:31
anatolybolshakov
anatolybolshakov approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you please take a look at comments also?

@egor-bryzgalov egor-bryzgalov requested a review from a team December 28, 2020 16:19
@egor-bryzgalov
Copy link
Member Author

Merge at 182 sprint

@egor-bryzgalov egor-bryzgalov merged commit b39750d into master Feb 19, 2021
@egor-bryzgalov egor-bryzgalov deleted the users/egor-bryzgalov/UsePython-node10 branch February 19, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-zaytsev max-zaytsev max-zaytsev approved these changes

@anatolybolshakov anatolybolshakov anatolybolshakov approved these changes

@leantk leantk Awaiting requested review from leantk

Assignees

@egor-bryzgalov egor-bryzgalov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egor-bryzgalov @anatolybolshakov @max-zaytsev