Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FtpUploadV1] Migrated legacy tests #14116

Merged
merged 13 commits into from
Dec 23, 2020
Merged

Conversation

max-zaytsev
Copy link

Task name: FtpUploadV1

Description: Migrated legacy tests

Documentation changes required: No

Added unit tests: Yes

Attached related issue: #353

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@max-zaytsev max-zaytsev requested a review from a team December 21, 2020 17:03
@anatolybolshakov
Copy link
Contributor

Thanks for migrating this! Do we need to remove legacy tests also?
I would also suggest to add some tests for successful - but maybe it makes sense to just create separate ticket for it.

@max-zaytsev
Copy link
Author

@anatolybolshakov

Thanks for migrating this! Do we need to remove legacy tests also?

Removed

I would also suggest to add some tests for successful - but maybe it makes sense to just create separate ticket for it.

Created a ticket: #630

@max-zaytsev max-zaytsev merged commit c68552f into master Dec 23, 2020
amit-avit pushed a commit to amit-avit/azure-pipelines-tasks that referenced this pull request Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants