[MavenV3] Migrated to Node 10

Tasks/MavenV3/Tests/TestUtils.ts

@@ -2,9 +2,8 @@ import * as fs from "fs";
 import * as path from "path";
 
 import { TaskMockRunner } from "azure-pipelines-task-lib/mock-run";
-import { FsOptions } from "azure-pipelines-task-lib/task";
 
-import { registerLocationHelpersMock } from 'packaging-common/Tests/MockHelper';
+import { registerLocationHelpersMock } from 'azure-pipelines-tasks-packaging-common/Tests/MockHelper';
 
 export interface MavenTaskInputs {
     mavenVersionSelection?: string;
@@ -86,6 +85,6 @@ export const initializeTest = (taskRunner: TaskMockRunner): void => {
     registerLocationHelpersMock(taskRunner);
 
     // Prevent file writes
-    taskRunner.registerMockExport("writefile", (file: string, data: string | Buffer, options?: string | FsOptions): void => {})
+    taskRunner.registerMockExport("writefile", (file: string, data: string | Buffer, options?: string | fs.WriteFileOptions): void => {})
     taskRunner.registerMockExport("cp", (source: string, dest: string, options?: string, continueOnError?: boolean): void => {})
 }

Tasks/MavenV3/maventask.ts

@@ -121,6 +121,10 @@ if (specifiedJavaHome) {
     tl.setVariable('JAVA_HOME', specifiedJavaHome);
 }
 
+function checkExistance(obj: any): Boolean {
+    return !!obj;
+}
+
 async function execBuild() {
     // Maven task orchestration occurs as follows:
     // 1. Check that Maven exists by executing it to retrieve its version.
@@ -249,7 +253,7 @@ async function execBuild() {
             userRunFailed = true; // Record the error and continue
         })
         .then(function (code) {
-            if (code && code['code'] != 0) {
+            if (checkExistance(code) && code['code'] != 0) {
                 userRunFailed = true;
             }
             // 4. Attempt to collate and upload static code analysis build summaries and artifacts.
@@ -357,7 +361,7 @@ function publishJUnitTestResults(testResultsFiles: string) {
 
     var tp = new tl.TestPublisher("JUnit");
     const testRunTitle = tl.getInput('testRunTitle');
-    tp.publish(matchingJUnitResultFiles, true, "", "", testRunTitle, true, TESTRUN_SYSTEM);
+    tp.publish(matchingJUnitResultFiles, 'true', "", "", testRunTitle, 'true', TESTRUN_SYSTEM);
 }
 
 function execEnableCodeCoverage(): Q.Promise<string> {

Tasks/MavenV3/mavenutil.ts

@@ -4,8 +4,8 @@ import path = require('path');
 import fs = require('fs');
 import * as tl from 'azure-pipelines-task-lib/task';
 import * as tr from 'azure-pipelines-task-lib/toolrunner';
-import * as pkgLocationUtils from "packaging-common/locationUtilities";
-import { logError } from 'packaging-common/util';
+import * as pkgLocationUtils from "azure-pipelines-tasks-packaging-common/locationUtilities";
+import { logError } from 'azure-pipelines-tasks-packaging-common/util';
 
 import * as url from "url";
 import * as xml2js from 'xml2js';