Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update download package v0 and v1 to use preview common npm package #14003

Merged
merged 5 commits into from
Dec 4, 2020
Merged

Update download package v0 and v1 to use preview common npm package #14003

merged 5 commits into from
Dec 4, 2020

Conversation

zhenghao104
Copy link
Contributor

Task name:

Description:

Documentation changes required: (Y/N)

Added unit tests: (Y/N)

Attached related issue: (Y/N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@zhenghao104 zhenghao104 requested a review from damccorm December 1, 2020 22:47
egor-bryzgalov
egor-bryzgalov reviewed Dec 2, 2020
View reviewed changes
Copy link
Member

@egor-bryzgalov egor-bryzgalov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it makes sense to remove make.json for the V1 task to avoid adding redundant dependencies during build.

Tasks/DownloadPackageV0/task.json Outdated Show resolved Hide resolved
Tasks/DownloadPackageV1/task.json Outdated Show resolved Hide resolved
Tasks/DownloadPackageV1/package.json Outdated Show resolved Hide resolved
Tasks/DownloadPackageV1/package.json Outdated Show resolved Hide resolved
egor-bryzgalov
egor-bryzgalov approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@egor-bryzgalov egor-bryzgalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@zhenghao104 zhenghao104 merged commit a8401c0 into master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egor-bryzgalov egor-bryzgalov egor-bryzgalov approved these changes

@aasim aasim Awaiting requested review from aasim

@phil-hodgson phil-hodgson Awaiting requested review from phil-hodgson

@satbai satbai Awaiting requested review from satbai

@damccorm damccorm Awaiting requested review from damccorm

@anatolybolshakov anatolybolshakov Awaiting requested review from anatolybolshakov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhenghao104 @anatolybolshakov @egor-bryzgalov