Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerShellV2] Migrated to Node10 #13891

Merged

Conversation

DaniilShmelev
Copy link
Contributor

@DaniilShmelev DaniilShmelev commented Nov 13, 2020

Includes changes to auto-generated resources.resjson and task.loc.json that were missing in #13122

Task name: PowerShell

Description: changed execution handler to Node10; updated dependencies; removed typings; updated mocha; updated tasklib version

Documentation changes required: No

Added unit tests: No

Attached related issue: https://github.com/microsoft/build-task-team/issues/334

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

Node6 backup branch

@DaniilShmelev DaniilShmelev requested review from damccorm and a team November 13, 2020 10:34
@DaniilShmelev DaniilShmelev changed the title [PowerShellV] Migrated to Node10 [PowerShellV2] Migrated to Node10 Nov 16, 2020
@egor-bryzgalov egor-bryzgalov merged commit cc65d6b into master Dec 7, 2020
@egor-bryzgalov egor-bryzgalov deleted the users/DaniilShmelev/PowerShell-node10-migration branch December 7, 2020 15:24
@maschmid-MSFT
Copy link

Started receiving a pipeline task timeout error with the Powershell task today and trying to figure out what's wrong with no luck so far. The task and script hasn't changed since I believe January and just now started failing. I know the script is running as I can see the output. At a certain point, there is a Wait-Event that is satisfied/triggered whenever a certain output string is written (we look for that string in output and then fire the event within the OutputDataReceived handler so our Wait-Event can continue. So it just sits there now on Wait-Event even though I can see the output that should fire the event. Anything I said ring a bell as far as this commit is concerned? Any ideas?

@anatolybolshakov
Copy link
Contributor

anatolybolshakov commented Dec 10, 2020

Hi @maschmid-MSFT this seems to be related to issue #14054 - could you please track progress about this one there?

@maschmid-MSFT
Copy link

Looks like a hotfix was released and verified that it does fix our issue. Quick turnaround. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants