[DeleteFilesV1] Migration of DeleteFilesV1 to node10 #13880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EzzhevNikita
force-pushed
the
users/EzzhevNikita/deletefiles-node10-migration
branch
from
23be0c2 to
ff709e1
Compare
anatolybolshakov
approved these changes
Nov 11, 2020
sdobrodeev
approved these changes
Nov 12, 2020
|
Can you also delete the entries in the Tests-Legacy folder related to DeleteFiles? |
Legacy tests removed, thank you! |
alex-peck
approved these changes
Nov 12, 2020
EzzhevNikita
force-pushed
the
users/EzzhevNikita/deletefiles-node10-migration
branch
from
1399873 to
69ac245
Compare
EzzhevNikita
deleted the
users/EzzhevNikita/deletefiles-node10-migration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: DeleteFilesV1
Description: Updated dependencies; Updated execution handler; Replaced deprecated methods MochaDone => Mocha.Done; Removed typings; Fixed typo path => curPath in removeFolder method in tests; Removed legacy tests;
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) Y
Checklist:
Node 6 backup branch