virtual directories are not created in AzureFileCopyV4 using blob prefix #13784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjgupta
approved these changes
Oct 27, 2020
2 tasks
jiasli
reviewed
Jan 11, 2024
| @@ -214,6 +214,7 @@ function Upload-FilesToAzureContainer | |||
|
|
|||
| $blobPrefix = $blobPrefix.Trim() | |||
| $containerURL = [string]::Format("{0}/{1}/{2}", $blobStorageEndpoint.Trim("/"), $containerName, $blobPrefix).Trim("/") | |||
| $containerURL = $containerURL + "/" | |||
There was a problem hiding this comment.
Before this PR and after #13976, $containerURL will never end with /. After this PR, $containerURL will always end with /.
I think a better solution would be not to trim / at L216 at all. Instead of calling it "Blob Prefix", call it "Destination". Keep it as is and pass it to azcopy. Leave its interpretation to azcopy: If 20220328.38/yum/, treat it as virtual directory. If 20220328.38/yum, treat it as blob name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: AzureFileCopyV4
Description: Added "/" at the end of destination blob storage url
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) https://developercommunity.visualstudio.com/content/problem/1109500/azure-file-copy-task-drops-file-name-when-using-pr.html
Checklist: