Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Conda* to azure-pipelines-task-lib #12410

Merged
merged 6 commits into from
Mar 5, 2020

Conversation

lkillgore
Copy link
Contributor

to fix node security patch warning

Tested by running L0's.

@lkillgore lkillgore requested a review from leantk as a code owner February 24, 2020 21:11
import { getPlatform } from './taskutil';
import { condaEnvironment } from './conda';

(async () => {
try {
task.setResourcePath(path.join(__dirname, 'task.json'));
await condaEnvironment({
environmentName: task.getInput('environmentName', true),
environmentName: task.getInput('environmentName', true)!,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that ! be there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! That's says the value returned is not-null, and suppresses the compiler error. (and, we know the value is non-null because we're supplying true to getInput.)

@lkillgore lkillgore force-pushed the users/lukillgo/1670736-conda branch from 2f1ecc4 to 30d25ec Compare March 4, 2020 22:21
@lkillgore lkillgore force-pushed the users/lukillgo/1670736-conda branch from 4a70537 to b9943ea Compare March 5, 2020 13:16
@lkillgore lkillgore merged commit ec71204 into master Mar 5, 2020
@lkillgore lkillgore deleted the users/lukillgo/1670736-conda branch March 5, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants