Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure SSH handshake timeout for CopyFilesOverSSH task. #12281

Merged
merged 8 commits into from
Feb 4, 2020

Conversation

triforcely
Copy link
Contributor

@triforcely triforcely commented Feb 3, 2020

This pull request solves half of the problem described in issue #12280. (half because I'd like to make this contribution to all SSH tasks)

Please advise whether:

  • this PR is welcome in this repository
  • how to handle missing resources (was it a good idea to use English placeholders for all languages?)
  • the version of the task should be changed
  • anything is missing

@msftclas
Copy link

msftclas commented Feb 3, 2020

CLA assistant check
All CLA requirements met.

@triforcely triforcely requested a review from damccorm February 4, 2020 19:16
Copy link

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damccorm damccorm merged commit 150d937 into microsoft:master Feb 4, 2020
@damccorm
Copy link

damccorm commented Feb 4, 2020

Thanks for the contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants