Support failOnStdErr on Helm Task #12211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vithati
suggested changes
Jan 27, 2020
Tasks/HelmDeployV0/src/helm.ts
Outdated
| @@ -73,6 +73,7 @@ async function run() { | |||
| command: command, | |||
| jobId: tl.getVariable('SYSTEM_JOBID') | |||
| }; | |||
| var failOnStderr = tl.getBoolInput("failOnStderr", true); | |||
There was a problem hiding this comment.
it is not mandatory input so keep false.
Increase task.json minor version to 165 and patchversion to 0.
vithati
suggested changes
Jan 30, 2020
Tasks/HelmDeployV0/task.json
Outdated
| @@ -13,7 +13,7 @@ | |||
| "author": "Microsoft Corporation", | |||
| "version": { | |||
| "Major": 0, | |||
| "Minor": 165, | |||
| "Minor": 166, | |||
There was a problem hiding this comment.
I should be 165 and Patch version should be 1.
0.165.1
please make change in task.loc.json also and add new strings to strings/en-US/resources.resjson.
Follow https://github.com/microsoft/azure-pipelines-tasks/blob/master/docs/contribute.md to build task if you build task it automatically do changes in task.loca.json and adds new string to resources files.
vithati
approved these changes
Feb 4, 2020
shigupt202
pushed a commit
that referenced
this pull request
Feb 12, 2020
* add failOnStdErr to helm
shigupt202
added a commit
that referenced
this pull request
Feb 12, 2020
* Support failOnStdErr on Helm Task (#12211) * add failOnStdErr to helm * Updating task version * Updating task version Co-authored-by: balteravishay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue 1660207: In Helm3 some of the commands writing output to stderr due to this even deployment successful, task showing fail because task look at stderr and if any data exist it fails
Suggested fix: