Added additional logs to identify script errors #12159
Conversation
| @@ -11,18 +11,19 @@ $__vsts_input_failOnStandardError = Get-VstsInput -Name FailOnStandardError | |||
| $targetAzurePs = Get-VstsInput -Name TargetAzurePs | |||
| $customTargetAzurePs = Get-VstsInput -Name CustomTargetAzurePs | |||
|
|
|||
| Write-Host "## Stage 1: Input Validation" | |||
There was a problem hiding this comment.
you can skip "stage 1". Just "## Validating inputs" would be fine.
|
|
||
| Write-Host "## Stage 2: Initialize Azure" |
| @@ -74,10 +78,27 @@ catch | |||
|
|
|||
| Update-PSModulePathForHostedAgent -targetAzurePs $targetAzurePs -authScheme $authScheme | |||
|
|
|||
| # troubleshoot link | |||
| $troubleshoot = "https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/deploy/azure-powershell?view=azure-devops#troubleshooting" | |||
There was a problem hiding this comment.
Make this a forward link instead.
| @@ -74,10 +78,27 @@ catch | |||
|
|
|||
| Update-PSModulePathForHostedAgent -targetAzurePs $targetAzurePs -authScheme $authScheme | |||
|
|
|||
| # troubleshoot link | |||
| $troubleshoot = "https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/deploy/azure-powershell?view=azure-devops#troubleshooting" | |||
| $status = $true | |||
There was a problem hiding this comment.
you do not need to define this variable here. You can set it directly after the write-host statement.
| try { | ||
| # Initialize Azure. | ||
| Import-Module $PSScriptRoot\ps_modules\VstsAzureHelpers_ | ||
| Initialize-Azure -azurePsVersion $targetAzurePs -strict | ||
| Write-Host "## Stage 2: Initialize Azure Complete" | ||
| } | ||
| catch { |
There was a problem hiding this comment.
don't need catch here. In 'finally' block, check for whether or not status is exists. That will work.
| } | ||
| finally { | ||
| if (!$status) { | ||
| Write-Host "## Initialize Azure failed: For troubleshooting, refer: $troubleshoot" |
There was a problem hiding this comment.
Instead of using Write-Host here try using Write-VstsError
| finally { | ||
| if (!$success) { | ||
| Write-VstsTaskError "Initialize Azure failed: For troubleshooting, refer: $troubleshoot" | ||
| } |
There was a problem hiding this comment.
there should also be a message saying "Azure initialization complete"
There was a problem hiding this comment.
have added this log "Write-Host "## Initializing Azure Complete"" after Initialize-Azure is completed
No description provided.