Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GithubRelease error when detecting endpoint token #12049

Merged
merged 4 commits into from
Mar 2, 2020
Merged

Fix GithubRelease error when detecting endpoint token #12049

merged 4 commits into from
Mar 2, 2020

Conversation

ljvmiranda921
Copy link
Contributor

@ljvmiranda921 ljvmiranda921 commented Dec 28, 2019

Reference: #11558

The endpoint object scheme being detected when service connection is made from the UI is Token, not PersonalAccessToken. I added the Token scheme so that this type gets passed.

In the meantime, I wrote a workaround here: https://ljvmiranda921.github.io/notebook/2019/12/28/workaround-azure-github-pat/ (in case this link hasn't been merged yet)

cc @romil07 @Lovakumar

The endpoint object scheme being detected when service connection is made from the UI is `Token`, not `PersonalAccessToken`.
@msftclas
Copy link

msftclas commented Dec 28, 2019

CLA assistant check
All CLA requirements met.

@hecflores
Copy link

Is this still waiting for approvers... I ran into this issue today and was wondering when can I expect to see this fix in the live site. Region Central US

@ljvmiranda921
Copy link
Contributor Author

Yup @hecflores , still waiting for reviewers. For the meantime, I wrote a workaround here: https://ljvmiranda921.github.io/notebook/2019/12/28/workaround-azure-github-pat/

@jakeholland
Copy link

I also ran into this issue today. Very frustrating that this has not been looked at.

Copy link

@bunkerdives bunkerdives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly the fix required to enable Github PATs to work properly for creating releases, etc.

Copy link

@bunkerdives bunkerdives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, fixes Github Issue #11558

@RTodorov
Copy link

RTodorov commented Feb 2, 2020

Hello folks,

Any idea when this fix will be merged and released? It's basically blocking the usage of the extension unless we do OAuth, which is not ideal for a lot of people.

@JSalazar88 @jakeholland

Thank you

@guthriec
Copy link

guthriec commented Feb 7, 2020

I also would like this to get merged please!

@RTodorov
Copy link

RTodorov commented Feb 7, 2020

@jalajmsft @bishal-pdMSFT sorry for tagging you here but this seems like an easy merge that would help a lot of people.

Thank you!

@bishal-pdMSFT
Copy link
Contributor

@RaghuJ80 and @romil07 please take a look

Copy link

@past-due past-due left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does indeed fix #11558

@RTodorov
Copy link

RTodorov commented Mar 2, 2020

@RaghuJ80 @romil07 any news on this one?

@romil07
Copy link
Contributor

romil07 commented Mar 2, 2020

@ljvmiranda921 I missed this.
And about this issue, what you have done is correct but I am looking at a way to avoid this altogether.
I will come back with an update.

@romil07 romil07 self-requested a review March 2, 2020 13:02
@romil07 romil07 merged commit 85d8002 into microsoft:master Mar 2, 2020
@romil07
Copy link
Contributor

romil07 commented Mar 2, 2020

@ljvmiranda921
I have merged your commit to master.
This will be available to you with next sprint deployment. I am not going to hotfix this since you already have a work around for now.

@ljvmiranda921
Copy link
Contributor Author

Thank you so much @romil07 !!

Copy link

@akankshakothari akankshakothari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.