-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GithubRelease error when detecting endpoint token #12049
Conversation
The endpoint object scheme being detected when service connection is made from the UI is `Token`, not `PersonalAccessToken`.
Is this still waiting for approvers... I ran into this issue today and was wondering when can I expect to see this fix in the live site. Region Central US |
Yup @hecflores , still waiting for reviewers. For the meantime, I wrote a workaround here: https://ljvmiranda921.github.io/notebook/2019/12/28/workaround-azure-github-pat/ |
I also ran into this issue today. Very frustrating that this has not been looked at. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly the fix required to enable Github PATs to work properly for creating releases, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, fixes Github Issue #11558
Hello folks, Any idea when this fix will be merged and released? It's basically blocking the usage of the extension unless we do OAuth, which is not ideal for a lot of people. @JSalazar88 @jakeholland Thank you |
I also would like this to get merged please! |
@jalajmsft @bishal-pdMSFT sorry for tagging you here but this seems like an easy merge that would help a lot of people. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does indeed fix #11558
@ljvmiranda921 I missed this. |
@ljvmiranda921 |
Thank you so much @romil07 !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good
Reference: #11558
The endpoint object scheme being detected when service connection is made from the UI is
Token
, notPersonalAccessToken
. I added theToken
scheme so that this type gets passed.In the meantime, I wrote a workaround here: https://ljvmiranda921.github.io/notebook/2019/12/28/workaround-azure-github-pat/ (in case this link hasn't been merged yet)
cc @romil07 @Lovakumar