Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfp warning and helpurl #12041

Merged
merged 3 commits into from
Dec 27, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Tasks/AzureAppServiceSettingsV1/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 160,
"Patch": 3
"Minor": 163,
"Patch": 0
},
"preview": "true",
"minimumAgentVersion": "2.104.1",
Expand Down
4 changes: 2 additions & 2 deletions Tasks/AzureAppServiceSettingsV1/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 160,
"Patch": 3
"Minor": 163,
"Patch": 0
},
"preview": "true",
"minimumAgentVersion": "2.104.1",
Expand Down
6 changes: 3 additions & 3 deletions Tasks/AzureFunctionAppContainerV1/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "AzureFunctionAppContainer",
"friendlyName": "Azure Functions for container",
"description": "Update a function app with a Docker container",
"helpUrl": "https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-rm-functionapp-containers",
"helpUrl": "https://aka.ms/azurefunctioncontainertroubleshooting",
"helpMarkDown": "[Learn more about this task](https://aka.ms/azurefunctiononcontainerdeployreadme)",
"category": "Deploy",
"visibility": [
Expand All @@ -17,8 +17,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 160,
"Patch": 2
"Minor": 163,
"Patch": 0
},
"minimumAgentVersion": "2.104.1",
"groups": [
Expand Down
6 changes: 3 additions & 3 deletions Tasks/AzureFunctionAppContainerV1/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "AzureFunctionAppContainer",
"friendlyName": "ms-resource:loc.friendlyName",
"description": "ms-resource:loc.description",
"helpUrl": "https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-rm-functionapp-containers",
"helpUrl": "https://aka.ms/azurefunctioncontainertroubleshooting",
"helpMarkDown": "ms-resource:loc.helpMarkDown",
"category": "Deploy",
"visibility": [
Expand All @@ -17,8 +17,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 160,
"Patch": 2
"Minor": 163,
"Patch": 0
},
"minimumAgentVersion": "2.104.1",
"groups": [
Expand Down
6 changes: 3 additions & 3 deletions Tasks/AzureFunctionAppV1/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "AzureFunctionApp",
"friendlyName": "Azure Functions",
"description": "Update a function app with .NET, Python, JavaScript, PowerShell, Java based web applications",
"helpUrl": "https://docs.microsoft.com/azure/devops/pipelines/tasks",
"helpUrl": "https://aka.ms/azurefunctiontroubleshooting",
"helpMarkDown": "[Learn more about this task](https://aka.ms/azurefunctiondeployreadme)",
"category": "Deploy",
"visibility": [
Expand All @@ -17,8 +17,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 160,
"Patch": 3
"Minor": 163,
"Patch": 0
},
"minimumAgentVersion": "2.104.1",
"groups": [
Expand Down
6 changes: 3 additions & 3 deletions Tasks/AzureFunctionAppV1/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "AzureFunctionApp",
"friendlyName": "ms-resource:loc.friendlyName",
"description": "ms-resource:loc.description",
"helpUrl": "https://docs.microsoft.com/azure/devops/pipelines/tasks",
"helpUrl": "https://aka.ms/azurefunctiontroubleshooting",
"helpMarkDown": "ms-resource:loc.helpMarkDown",
"category": "Deploy",
"visibility": [
Expand All @@ -17,8 +17,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 160,
"Patch": 3
"Minor": 163,
"Patch": 0
},
"minimumAgentVersion": "2.104.1",
"groups": [
Expand Down
6 changes: 3 additions & 3 deletions Tasks/AzureRmWebAppDeploymentV3/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "AzureRmWebAppDeployment",
"friendlyName": "Azure App Service deploy",
"description": "Deploy to Azure App Service a web, mobile, or API app using Docker, Java, .NET, .NET Core, Node.js, PHP, Python, or Ruby",
"helpUrl": "https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-rm-web-app-deployment",
"helpUrl": "https://aka.ms/azureappservicetroubleshooting",
"helpMarkDown": "[Learn more about this task](https://aka.ms/azurermwebdeployreadme)",
"category": "Deploy",
"visibility": [
Expand All @@ -17,8 +17,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 3,
"Minor": 160,
"Patch": 2
"Minor": 163,
"Patch": 0
},
"releaseNotes": "What's new in Version 3.0: <br/>&nbsp;&nbsp;Supports File Transformations (XDT) <br/>&nbsp;&nbsp;Supports Variable Substitutions(XML, JSON) <br/>Click [here](https://aka.ms/azurermwebdeployreadme) for more information.",
"minimumAgentVersion": "2.104.1",
Expand Down
6 changes: 3 additions & 3 deletions Tasks/AzureRmWebAppDeploymentV3/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "AzureRmWebAppDeployment",
"friendlyName": "ms-resource:loc.friendlyName",
"description": "ms-resource:loc.description",
"helpUrl": "https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-rm-web-app-deployment",
"helpUrl": "https://aka.ms/azureappservicetroubleshooting",
"helpMarkDown": "ms-resource:loc.helpMarkDown",
"category": "Deploy",
"visibility": [
Expand All @@ -17,8 +17,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 3,
"Minor": 160,
"Patch": 2
"Minor": 163,
"Patch": 0
},
"releaseNotes": "ms-resource:loc.releaseNotes",
"minimumAgentVersion": "2.104.1",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
import tl = require('azure-pipelines-task-lib/task');
import Q = require('q');
import path = require('path');
import { Kudu } from 'azure-arm-rest-v2/azure-arm-app-service-kudu';

import { DeploymentType, TaskParameters } from './TaskParameters';

import { AzureDeployPackageArtifactAlias } from './Constants';
import { KUDU_DEPLOYMENT_CONSTANTS } from 'azure-arm-rest-v2/constants';
import { Kudu } from 'azure-arm-rest-v2/azure-arm-app-service-kudu';

import webClient = require('azure-arm-rest-v2/webClient');
import { TaskParameters, DeploymentType } from './TaskParameters';
import { AzureDeployPackageArtifactAlias } from './Constants';

var deployUtility = require('webdeployment-common-v2/utility.js');
var zipUtility = require('webdeployment-common-v2/ziputility.js');
const physicalRootPath: string = '/site/wwwroot';
Expand Down Expand Up @@ -195,6 +199,7 @@ export class KuduServiceUtility {
queryParameters.push('message=' + encodeURIComponent(deploymentMessage));
await this._appServiceKuduService.zipDeploy(packagePath, queryParameters);
console.log(tl.loc('PackageDeploymentSuccess'));
console.log("NOTE: Run From Package makes wwwroot read-only, so you will receive an error when writing files to this directory.");
}
catch(error) {
tl.error(tl.loc('PackageDeploymentFailed'));
Expand Down
6 changes: 3 additions & 3 deletions Tasks/AzureRmWebAppDeploymentV4/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "AzureRmWebAppDeployment",
"friendlyName": "Azure App Service deploy",
"description": "Deploy to Azure App Service a web, mobile, or API app using Docker, Java, .NET, .NET Core, Node.js, PHP, Python, or Ruby",
"helpUrl": "https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-rm-web-app-deployment",
"helpUrl": "https://aka.ms/azureappservicetroubleshooting",
"helpMarkDown": "[Learn more about this task](https://aka.ms/azurermwebdeployreadme)",
"category": "Deploy",
"visibility": [
Expand All @@ -17,8 +17,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 4,
"Minor": 160,
"Patch": 3
"Minor": 163,
"Patch": 0
},
"releaseNotes": "What's new in version 4.*<br />Supports Zip Deploy, Run From Package, War Deploy [Details here](https://aka.ms/appServiceDeploymentMethods)<br />Supports App Service Environments<br />Improved UI for discovering different App service types supported by the task<br/>Run From Package is the preferred deployment method, which makes files in wwwroot folder read-only<br/>Click [here](https://aka.ms/azurermwebdeployreadme) for more information.",
"minimumAgentVersion": "2.104.1",
Expand Down
6 changes: 3 additions & 3 deletions Tasks/AzureRmWebAppDeploymentV4/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "AzureRmWebAppDeployment",
"friendlyName": "ms-resource:loc.friendlyName",
"description": "ms-resource:loc.description",
"helpUrl": "https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-rm-web-app-deployment",
"helpUrl": "https://aka.ms/azureappservicetroubleshooting",
"helpMarkDown": "ms-resource:loc.helpMarkDown",
"category": "Deploy",
"visibility": [
Expand All @@ -17,8 +17,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 4,
"Minor": 160,
"Patch": 3
"Minor": 163,
"Patch": 0
},
"releaseNotes": "ms-resource:loc.releaseNotes",
"minimumAgentVersion": "2.104.1",
Expand Down
6 changes: 3 additions & 3 deletions Tasks/AzureWebAppContainerV1/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "AzureWebAppContainer",
"friendlyName": "Azure Web App for Containers",
"description": "Deploy containers to Azure App Service",
"helpUrl": "https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-rm-web-app-containers",
"helpUrl": "https://aka.ms/azurewebappcontainertroubleshooting",
"helpMarkDown": "[Learn more about this task](https://aka.ms/azurewebapponcontainerdeployreadme)",
"category": "Deploy",
"visibility": [
Expand All @@ -17,8 +17,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 160,
"Patch": 2
"Minor": 163,
"Patch": 0
},
"minimumAgentVersion": "2.104.1",
"groups": [
Expand Down
6 changes: 3 additions & 3 deletions Tasks/AzureWebAppContainerV1/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "AzureWebAppContainer",
"friendlyName": "ms-resource:loc.friendlyName",
"description": "ms-resource:loc.description",
"helpUrl": "https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-rm-web-app-containers",
"helpUrl": "https://aka.ms/azurewebappcontainertroubleshooting",
"helpMarkDown": "ms-resource:loc.helpMarkDown",
"category": "Deploy",
"visibility": [
Expand All @@ -17,8 +17,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 160,
"Patch": 2
"Minor": 163,
"Patch": 0
},
"minimumAgentVersion": "2.104.1",
"groups": [
Expand Down
6 changes: 3 additions & 3 deletions Tasks/AzureWebAppV1/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "AzureWebApp",
"friendlyName": "Azure Web App",
"description": "Deploy an Azure Web App for Linux or Windows",
"helpUrl": "https://docs.microsoft.com/azure/devops/pipelines/tasks",
"helpUrl": "https://aka.ms/azurewebapptroubleshooting",
"helpMarkDown": "[Learn more about this task](https://aka.ms/azurewebappdeployreadme)",
"category": "Deploy",
"visibility": [
Expand All @@ -17,8 +17,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 160,
"Patch": 5
"Minor": 163,
"Patch": 0
},
"minimumAgentVersion": "2.104.1",
"groups": [
Expand Down
6 changes: 3 additions & 3 deletions Tasks/AzureWebAppV1/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "AzureWebApp",
"friendlyName": "ms-resource:loc.friendlyName",
"description": "ms-resource:loc.description",
"helpUrl": "https://docs.microsoft.com/azure/devops/pipelines/tasks",
"helpUrl": "https://aka.ms/azurewebapptroubleshooting",
"helpMarkDown": "ms-resource:loc.helpMarkDown",
"category": "Deploy",
"visibility": [
Expand All @@ -17,8 +17,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 160,
"Patch": 5
"Minor": 163,
"Patch": 0
},
"minimumAgentVersion": "2.104.1",
"groups": [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
import tl = require('azure-pipelines-task-lib/task');
import Q = require('q');
import path = require('path');
import { Kudu } from '../azure-arm-rest/azure-arm-app-service-kudu';

import { AzureDeployPackageArtifactAlias } from '../Constants';
import { KUDU_DEPLOYMENT_CONSTANTS } from '../azure-arm-rest/constants';
import { Kudu } from '../azure-arm-rest/azure-arm-app-service-kudu';

import webClient = require('../azure-arm-rest/webClient');
import { AzureDeployPackageArtifactAlias } from '../Constants';

var deployUtility = require('../webdeployment-common/utility.js');
var zipUtility = require('../webdeployment-common/ziputility.js');
const physicalRootPath: string = '/site/wwwroot';
Expand Down Expand Up @@ -128,6 +131,7 @@ export class KuduServiceUtility {
queryParameters.push('message=' + encodeURIComponent(deploymentMessage));
await this._appServiceKuduService.zipDeploy(packagePath, queryParameters);
console.log(tl.loc('PackageDeploymentSuccess'));
console.log("NOTE: Run From Package makes wwwroot read-only, so you will receive an error when writing files to this directory.");
}
catch(error) {
let stackTraceUrl:string = this._appServiceKuduService.getKuduStackTrace();
Expand Down