SPN Auth credential bug fix for ARG and PackerBuild tasks #11994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issacnitin
requested review from
bishal-pdMSFT and
vinodkumar3
as code owners
issacnitin
changed the title
issacnitin
requested review from
Ajay-MS,
Anumita,
prebansa and
vithati
as code owners
|
Customer reported an issue that one string is not defined properly. please fix that as well. |
bishal-pdMSFT
approved these changes
Dec 20, 2019
…-tasks into users/nijoy/arg_task_bug_fix_spn
issacnitin
pushed a commit
that referenced
this pull request
Jan 5, 2020
* spn auth credential bug fix for ARG task * SPN Auth Credential Bug fix for PackerBuild task * Refactoring bug fix to utilize arm-endpoint function * Refactoring PackerBuildV1 as well * Updating task version due to Common library change * Avoiding package-lock.json * Bug fix * Review comments * Bug fix * Bug fix * Bug fix * bug fix * Merge conflict resolutions * Bug fix
issacnitin
pushed a commit
that referenced
this pull request
Jan 6, 2020
* spn auth credential bug fix for ARG task * SPN Auth Credential Bug fix for PackerBuild task * Refactoring bug fix to utilize arm-endpoint function * Refactoring PackerBuildV1 as well * Updating task version due to Common library change * Avoiding package-lock.json * Bug fix * Review comments * Bug fix * Bug fix * Bug fix * bug fix * Merge conflict resolutions * Bug fix
issacnitin
pushed a commit
that referenced
this pull request
Jan 6, 2020
* Revert "Revert spn issue commit (#11991)" This reverts commit 1b4b067. * SPN Bug fix for using certificate based Auth * Revert "SPN Bug fix for using certificate based Auth" This reverts commit bea17b3. * Revert "Revert "Revert spn issue commit (#11991)"" This reverts commit 0265f11. * SPN Auth credential bug fix for ARG and PackerBuild tasks (#11994) * spn auth credential bug fix for ARG task * SPN Auth Credential Bug fix for PackerBuild task * Refactoring bug fix to utilize arm-endpoint function * Refactoring PackerBuildV1 as well * Updating task version due to Common library change * Avoiding package-lock.json * Bug fix * Review comments * Bug fix * Bug fix * Bug fix * bug fix * Merge conflict resolutions * Bug fix * Updating task versions * Updating task versions * Updating ARG task version * Updating PackerBuild task versions * PackerBuildV0 Bug fix * Updating some more task versions * Review comments * Bug fix * Review comment * Bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.