Port to m161: AzureResourceGroupDeployment: Improve docs/error logs to surface SPN details to user #11909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…details to user (#11860) * Init * Adding Graph calls to retrieve and filter by Service Principal * Refactoring * Removing calls to get roleAssignments * Removing debug logs * Improving error message * Removing unnecessary imports * Incrementing task version * Removing code in common folder * Adding functionality for AzureResourceGroupDeploymentV2 * Revert "Adding functionality for AzureResourceGroupDeploymentV2" This reverts commit 2400c26. * Review comments * Updating L0 tests * Updating L0 Tests * Review comments * Using tl.debug() * Fixing L0 test * Bug fix * Updating task version * Updating Graph URL in L0 tests * Debugging L0 failure * Debugging L0 * Removing debug stuff * Increasing test timeout * Test timeout back to 30 seconds * Removing ARGV2 version to see if test runs fine * Revert * Revert2 * Revert "Revert2" This reverts commit 33b894b. * Revert "Revert" This reverts commit a105046. * Revert "Removing ARGV2 version to see if test runs fine" This reverts commit 12c4e3f. * Updating task version * Adding Azure-Graph mock for L0 * Adding necessary parameters to azure-graph mock
issacnitin
requested review from
bishal-pdMSFT and
vinodkumar3
as code owners
Tasks/AzureResourceManagerTemplateDeploymentV3/operations/DeploymentScopeBase.ts
Outdated
Show resolved
Hide resolved
Tasks/AzureResourceManagerTemplateDeploymentV3/operations/DeploymentScopeBase.ts
Outdated
Show resolved
Hide resolved
…pelines-tasks into users/nijoy/arg_task_fix2_m161_port2
Tasks/AzureResourceManagerTemplateDeploymentV3/operations/DeploymentScopeBase.ts
Show resolved
Hide resolved
bishal-pdMSFT
approved these changes
Dec 6, 2019
|
Please port some the additional change you did to master as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…details to user (#11860)
Init
Adding Graph calls to retrieve and filter by Service Principal
Refactoring
Removing calls to get roleAssignments
Removing debug logs
Improving error message
Removing unnecessary imports
Incrementing task version
Removing code in common folder
Adding functionality for AzureResourceGroupDeploymentV2
Revert "Adding functionality for AzureResourceGroupDeploymentV2"
This reverts commit 2400c26.
Review comments
Updating L0 tests
Updating L0 Tests
Review comments
Using tl.debug()
Fixing L0 test
Bug fix
Updating task version
Updating Graph URL in L0 tests
Debugging L0 failure
Debugging L0
Removing debug stuff
Increasing test timeout
Test timeout back to 30 seconds
Removing ARGV2 version to see if test runs fine
Revert
Revert2
Revert "Revert2"
This reverts commit 33b894b.
This reverts commit a105046.
This reverts commit 12c4e3f.
Updating task version
Adding Azure-Graph mock for L0
Adding necessary parameters to azure-graph mock