Fixed DownloadPackageV0 task to be able to download AFD enabled packages #11897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham90
reviewed
Dec 4, 2019
| options.host && | ||
| options.host.endsWith("blob.core.windows.net") && | ||
| options.path && | ||
| options.path.includes("&sig=") |
There was a problem hiding this comment.
why are we removing this check?
There was a problem hiding this comment.
I used the updated library for this task that uses Regex to match the urls. The regex using just the hostname works as well, and its too complicated with additional options.
shubham90
reviewed
Dec 4, 2019
| @@ -10,7 +10,7 @@ | |||
| "version": { | |||
| "Major": 0, | |||
| "Minor": 161, | |||
| "Patch": 0 | |||
There was a problem hiding this comment.
I though you already made this 161.2? shouldn't this be more than that?
There was a problem hiding this comment.
This is DownloadPackageV0. The 161.2 was for DownloadPackageV1
shubham90
approved these changes
Dec 4, 2019
aasim
added a commit
that referenced
this pull request
Dec 4, 2019
aasim
added a commit
that referenced
this pull request
Dec 4, 2019
leantk
pushed a commit
that referenced
this pull request
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.