[KubernetesManifest] Replacement logic fix #11883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vithati
suggested changes
Dec 5, 2019
| KubernetesObjectUtility.updateImagePullSecrets(inputObject, imagePullSecrets, false); | ||
| } | ||
| newObjectsList.push(inputObject); | ||
| if (!!containers && containers.length > 0) { |
Tasks/KubernetesManifestV0/src/utils/KubernetesObjectUtility.ts
Outdated
Show resolved
Hide resolved
vithati
approved these changes
Dec 9, 2019
| img = imageName.split(':')[0]; | ||
| } | ||
| images.forEach(image => { | ||
| if (image.startsWith(img + ':') || image === img) { |
There was a problem hiding this comment.
if it is same then no need to replace right. image===img we can remove.
There was a problem hiding this comment.
Good point. The check should be different. I'll fix it
vithati
reviewed
Dec 9, 2019
| KubernetesObjectUtility.updateImagePullSecrets(inputObject, imagePullSecrets, false); | ||
| } | ||
| newObjectsList.push(inputObject); | ||
| if (containers && containers.length > 0) { |
leantk
pushed a commit
that referenced
this pull request
Dec 23, 2019
* [KubernetesManifest] Replacement logic fix * Resolving comments and some extra logic * Adding list support/fixing logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11517