AzureResourceGroupDeploymentTask: Improving error log to point to Deployment logs in Ibiza Portal #11853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issacnitin
requested review from
bishal-pdMSFT and
vinodkumar3
as code owners
Co-Authored-By: Bishal Prasad <[email protected]>
Tasks/AzureResourceManagerTemplateDeploymentV3/operations/DeploymentScopeBase.ts
Outdated
Show resolved
Hide resolved
Tasks/AzureResourceManagerTemplateDeploymentV3/operations/DeploymentScopeBase.ts
Outdated
Show resolved
Hide resolved
bishal-pdMSFT
suggested changes
Nov 29, 2019
…oft/azure-pipelines-tasks into users/nijoy/arg_task_fix1
Tasks/AzureResourceManagerTemplateDeploymentV3/operations/DeploymentScopeBase.ts
Outdated
Show resolved
Hide resolved
Tasks/AzureResourceManagerTemplateDeploymentV3/operations/DeploymentScopeBase.ts
Outdated
Show resolved
Hide resolved
Tasks/AzureResourceGroupDeploymentV2/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
bishal-pdMSFT
approved these changes
Dec 3, 2019
|
please also port it to M161 branch |
…-tasks into users/nijoy/arg_task_fix1
…oft/azure-pipelines-tasks into users/nijoy/arg_task_fix1
issacnitin
pushed a commit
that referenced
this pull request
Dec 5, 2019
…loyment logs in Ibiza Portal (#11853) * Init * Refactoring * Update Tasks/AzureResourceManagerTemplateDeploymentV3/task.json Co-Authored-By: Bishal Prasad <[email protected]> * Adding functionality for AzureResourceGroupDeploymentV2 * Updating error message * Handling deploymentScope as Resource Group * Handling management group * Updating message * Review comments * Updating task version * Bug fix * Print log for subscription as well * Bug fix
issacnitin
pushed a commit
that referenced
this pull request
Dec 6, 2019
…o point to Deployment logs in Ibiza Portal (#11853) (#11904) * AzureResourceGroupDeploymentTask: Improving error log to point to Deployment logs in Ibiza Portal (#11853) * Init * Refactoring * Update Tasks/AzureResourceManagerTemplateDeploymentV3/task.json Co-Authored-By: Bishal Prasad <[email protected]> * Adding functionality for AzureResourceGroupDeploymentV2 * Updating error message * Handling deploymentScope as Resource Group * Handling management group * Updating message * Review comments * Updating task version * Bug fix * Print log for subscription as well * Bug fix * Adding check for Subscription * Bug fix * Bug fix * 500 errors are shown * Bug fix * Bug fix
vineetmimrot
added a commit
that referenced
this pull request
Dec 17, 2019
* Revert "ARG Task Review comments from release PR to master (#11916)" This reverts commit e585a5f. * Revert "AzureResourceGroupDeployment: Improve docs/error logs to surface SPN details to user (#11860)" This reverts commit 2f363fc. * Revert "AzureResourceGroupDeploymentTask: Improving error log to point to Deployment logs in Ibiza Portal (#11853)" This reverts commit 8f02a1c. * update version * update version
leantk
pushed a commit
that referenced
this pull request
Dec 23, 2019
…loyment logs in Ibiza Portal (#11853) * Init * Refactoring * Update Tasks/AzureResourceManagerTemplateDeploymentV3/task.json Co-Authored-By: Bishal Prasad <[email protected]> * Adding functionality for AzureResourceGroupDeploymentV2 * Updating error message * Handling deploymentScope as Resource Group * Handling management group * Updating message * Review comments * Updating task version * Bug fix * Print log for subscription as well * Bug fix
issacnitin
pushed a commit
that referenced
this pull request
Jan 2, 2020
* Revert "ARG Task Review comments from release PR to master (#11916)" This reverts commit e585a5f. * Revert "AzureResourceGroupDeployment: Improve docs/error logs to surface SPN details to user (#11860)" This reverts commit 2f363fc. * Revert "AzureResourceGroupDeploymentTask: Improving error log to point to Deployment logs in Ibiza Portal (#11853)" This reverts commit 8f02a1c. * Updating task version for ARGV3 * Updating ARG-v3 task version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mseng.visualstudio.com/AzureDevOps/_workitems/edit/1647742