Using the ToolLib to download and cache the tool #11825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyash691
reviewed
Nov 25, 2019
suyash691
reviewed
Nov 25, 2019
suyash691
approved these changes
Nov 25, 2019
vithati
suggested changes
Nov 25, 2019
dabasnidhi
reviewed
Nov 25, 2019
vithati
suggested changes
Nov 25, 2019
vithati
approved these changes
Nov 26, 2019
navin22
added a commit
to navin22/vsts-tasks
that referenced
this pull request
Nov 26, 2019
* Using the ToolLib to download and cache the tool
navin22
added a commit
that referenced
this pull request
Nov 27, 2019
leantk
pushed a commit
that referenced
this pull request
Dec 23, 2019
* Using the ToolLib to download and cache the tool * changing the error message. * PR comments resolved. * using only which with true as second argument instead of the existSync. * Not using which to identify if tool exists. As it checks using PATH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will fix the bug https://github.com/MicrosoftDocs/vsts-docs/issues/6067, if the container-structure-test tool is in the same folder as the task.
Then there's a ETXTBSY error thrown as the file will be opened in node, as the tool is in the task folder.
This was happening in the hosted agents, if the tool is in the $PATH with the name "container-structure-test", it will work. Hence couldn't catch earlier.
With the toollib the tool will be in _tools folder, and it's an improvement as well we will be downloading the tool only once.