added .net core 3.0 information and fixed bug for modify output path #11800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalajmsft
reviewed
Nov 21, 2019
Tasks/DotNetCoreCLIV2/dotnetcore.ts
Outdated
| return path.join(outputBase, path.basename(path.dirname(projectFile))); | ||
| let projectFileName = path.basename(projectFile); | ||
| let indexOfFileSeperator = projectFileName.indexOf('.'); | ||
| projectFileName = projectFileName.slice(0, indexOfFileSeperator ? indexOfFileSeperator : projectFileName.length); |
There was a problem hiding this comment.
Can filename not have '.'?
There was a problem hiding this comment.
They should have '.' always when its a csproj file. But at least on windows, file without extensions can exist, hence handled that.
There was a problem hiding this comment.
What I meant was what if there are multiple '.' in the file name, for example "a.b.extension". Is this possible?
There was a problem hiding this comment.
yeah that's right....
But removed the logic of file name now. Nice catch
|
@bishal-pdMSFT I made the change to not take the folder of Project file as the project name, but rather take the project file name as the project name. |
2. Revert output folder modification behaviour
bishal-pdMSFT
approved these changes
Nov 22, 2019
… command exection fails
leantk
pushed a commit
that referenced
this pull request
Dec 23, 2019
…11800) * added .net core 3.0 information and fixed bug for modify output path * fixed test * 1. Display message at the end 2. Revert output folder modification behaviour * Rephrased the infromational message * Changed message and added the message to be displayed as warning when command exection fails * Message will only be shown as warning if command is publish * Fixed for message to be printed only once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.