Adding results directory UI option in vstest task #11789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vagisha-nidhi
commented
Nov 18, 2019
vagisha-nidhi
commented
vagisha-nidhi
requested review from
SadagopanRajaram and
ShreyasRmsft
as code owners
vagisha-nidhi
commented
Nov 18, 2019
vagisha-nidhi
commented
Nov 18, 2019
PBoraMSFT
approved these changes
Nov 20, 2019
Tasks/VsTestV2/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
| @@ -22,6 +22,8 @@ | |||
| "loc.input.help.tcmTestRun": "Test run based selection is used when triggering automated test runs from the test hub. This option cannot be used for running tests in the CI/CD pipeline.", | |||
| "loc.input.label.searchFolder": "Search folder", | |||
| "loc.input.help.searchFolder": "Folder to search for the test assemblies.", | |||
| "loc.input.label.resultsDirectory": "Test results directory", | |||
| "loc.input.help.resultsDirectory": "Folder to store test results. The vstest task cleans up results directory before test run. $(Agent.TempDirectory) is cleaned after each pipeline run. In case the default value is overriden, the directory will not be automatically cleaned. When results directory is provided in both task and runsettings, the runsettings will be given priority.", | |||
There was a problem hiding this comment.
When both are provided, task should win. Other inputs in the task typically override runsettings inputs, so this should be consistent.
There was a problem hiding this comment.
Making this change in the dtaexecutionhost
Tasks/VsTestV2/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
Tasks/VsTestV2/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
Tasks/VsTestV2/inputparser.ts
Outdated
| @@ -166,6 +166,14 @@ function getTestReportingSettings(inputDataContract : idc.InputDataContract) : i | |||
| inputDataContract.TestReportingSettings.TestRunTitle = tl.getInput('testRunTitle'); | |||
| inputDataContract.TestReportingSettings.TestRunSystem = 'VSTS - vstest'; | |||
|
|
|||
| const resultsDir = path.resolve(tl.getVariable('System.DefaultWorkingDirectory'), tl.getInput('resultsFolder').trim()); | |||
Tasks/VsTestV2/inputparser.ts
Outdated
| { | ||
| inputDataContract.TestReportingSettings.TestResultsDirectory = resultsDir; | ||
| tl.debug("TestResultsFolder: " + resultsDir); | ||
| ci.publishEvent({ 'TestResultsFolderUi': resultsDir } ); |
There was a problem hiding this comment.
temp or more than temp path
common.test or
defaultdir
push this property of the path as you can't directly push path
There was a problem hiding this comment.
Added. Is there a better way to add this?
…ha-nidhi/azure-pipelines-tasks into users/vanidhi/resultdDirUI
ShreyasRmsft
approved these changes
Nov 26, 2019
ShreyasRmsft
reviewed
Dec 2, 2019
|
|
||
| if (resultsDir.startsWith(tl.getVariable('Agent.TempDirectory') + 'TestResults')) | ||
| { | ||
| ci.publishEvent({ 'TestResultsFolderUi': '$(Agent.TempDirectory)/TestResults' } ); |
There was a problem hiding this comment.
hey, can you add a customer feature name for this?
Other this event will have the same feature name as all the others and filtering on kusto won't be easy.
ShreyasRmsft
reviewed
Dec 2, 2019
| inputDataContract.TestReportingSettings.TestResultsDirectory = resultsDir; | ||
| tl.debug("TestResultsFolder: " + resultsDir); | ||
|
|
||
| if (resultsDir.startsWith(tl.getVariable('Agent.TempDirectory') + 'TestResults')) |
There was a problem hiding this comment.
did you verify if this has a slash at the end?
ShreyasRmsft
reviewed
Dec 2, 2019
| } | ||
| else if (resultsDir.startsWith(tl.getVariable('Agent.TempDirectory'))) | ||
| { | ||
| ci.publishEvent({ 'TestResultsFolderUi': '$(Agent.TempDirectory)' } ); |
There was a problem hiding this comment.
please keep an eye out for formatting, use tslint
ShreyasRmsft
reviewed
Dec 2, 2019
| if (resultsDir.startsWith(tl.getVariable('Agent.TempDirectory') + 'TestResults')) | ||
| { | ||
| ci.publishEvent({ 'TestResultsFolderUi': '$(Agent.TempDirectory)/TestResults' } ); | ||
| } |
There was a problem hiding this comment.
you can move this to a private function
leantk
pushed a commit
that referenced
this pull request
Dec 23, 2019
* Adding results directory UI option in vstest task * Addressing comments * Addressing PR comments * Updating test agent * Updating test agent version * Updating relative directory and adding telemetry * Update task.json * Update task.json * Updated help tect * Updating res.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.