bug fixes in Azure Webapp deploy task #11737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bishal-pdMSFT can you review this PR. |
|
@vineetmimrot can you please add some details about the bug? |
Done. Can you please approve it. |
| @@ -39,9 +39,7 @@ export class AzureRmWebAppDeploymentProvider implements IWebAppDeploymentProvide | |||
| this.kuduService = new Kudu(this.publishProfileScmCredentials.scmUri, this.publishProfileScmCredentials.username, this.publishProfileScmCredentials.password); | |||
| let resourceId = publishProfileEndpoint.resourceId; | |||
| let resourceIdSplit = resourceId.split("/"); | |||
| if (resourceIdSplit.length === 11) { | |||
| this.slotName = resourceIdSplit[10]; | |||
There was a problem hiding this comment.
can we not just use this.taskParams.SlotName for slotName
There was a problem hiding this comment.
In the case of publish profile, the input fields related to webapp are redundant. The artifact will be deployed only at the scm url present in the publish profile, irrespective of what the user provides value into input fields.
There was a problem hiding this comment.
Makes sense. Are the web app related inputs still visible in task ux?
There was a problem hiding this comment.
Lets take this out of this PR
bishal-pdMSFT
approved these changes
Nov 19, 2019
leantk
pushed a commit
that referenced
this pull request
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues:
In case of publish profile scenario, change the slot name to "production", if the deployment is done on main webApp.
minor fix for printing application url on console log.