Added deployment strategy for Linux Premium Plan #11736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SumiranAgg Tested the changes from Azure Function App. The package is getting deployed successfully. |
niadak
approved these changes
Nov 12, 2019
niadak
reviewed
Nov 12, 2019
| @@ -9,6 +9,7 @@ var zipUtility = require('azurermdeploycommon/webdeployment-common/ziputility.js | |||
|
|
|||
| const linuxFunctionStorageSetting: string = '-WEBSITES_ENABLE_APP_SERVICE_STORAGE true'; | |||
| const linuxFunctionRuntimeSettingName: string = '-FUNCTIONS_WORKER_RUNTIME '; | |||
| const premiumPlanRunsFromPackage: string = ' -WEBSITE_RUN_FROM_PACKAGE true'; | |||
There was a problem hiding this comment.
Is this relevant for other type of Apps or this is specific to FunctionApp?
There was a problem hiding this comment.
This is specific to function app
SumiranAgg
reviewed
Nov 19, 2019
| @@ -32,6 +33,10 @@ export class BuiltInLinuxWebAppDeploymentProvider extends AzureRmWebAppDeploymen | |||
| linuxFunctionRuntimeSetting = linuxFunctionRuntimeSettingName + linuxFunctionRuntimeSettingValue.get(this.taskParams.RuntimeStack); | |||
| } | |||
| var linuxFunctionAppSetting = linuxFunctionRuntimeSetting + linuxFunctionStorageSetting; | |||
| if(this.taskParams.isPremium) { | |||
There was a problem hiding this comment.
add !! before variable in if
SumiranAgg
reviewed
Nov 19, 2019
| @@ -9,6 +9,7 @@ var zipUtility = require('azurermdeploycommon/webdeployment-common/ziputility.js | |||
|
|
|||
| const linuxFunctionStorageSetting: string = '-WEBSITES_ENABLE_APP_SERVICE_STORAGE true'; | |||
| const linuxFunctionRuntimeSettingName: string = '-FUNCTIONS_WORKER_RUNTIME '; | |||
| const premiumPlanRunsFromPackage: string = ' -WEBSITE_RUN_FROM_PACKAGE true'; | |||
There was a problem hiding this comment.
should value be 1 or true
SumiranAgg
reviewed
Nov 19, 2019
SumiranAgg
approved these changes
Nov 19, 2019
leantk
pushed a commit
that referenced
this pull request
Dec 23, 2019
* Added deployment strategy for Linux Premium Plan * Changes for premium plan * Settings changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference : #11257
Fixes : #11256