Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update archiveFiles task lib version #11687

Merged
merged 4 commits into from
Nov 5, 2019
Merged

Conversation

damccorm
Copy link

@damccorm damccorm commented Nov 4, 2019

Right now the version of the task-lib used in archiveFiles doesn't let us use any of the mockery libs we have. This should be a pretty easy change even though its a big version bump, there's not a whole lot going on that uses the task-lib other than execing tools which is pretty straightforward.

@damccorm damccorm requested a review from jtpetty as a code owner November 4, 2019 19:14
Copy link
Contributor

@jtpetty jtpetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damccorm damccorm merged commit f346278 into master Nov 5, 2019
@damccorm damccorm deleted the users/damccorm/archiveFilesTests branch November 5, 2019 18:12
leantk pushed a commit that referenced this pull request Dec 23, 2019
* Update archiveFiles task lib version

* Missed test file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants