Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing failing L0 test #11617

Merged
merged 2 commits into from
Oct 22, 2019
Merged

removing failing L0 test #11617

merged 2 commits into from
Oct 22, 2019

Conversation

tejasd1990
Copy link
Contributor

No description provided.

jalajmsft
jalajmsft approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@jalajmsft jalajmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason to remove?

bishal-pdMSFT
bishal-pdMSFT approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@bishal-pdMSFT bishal-pdMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will ultimately change the test. Right?

@tejasd1990
Copy link
Contributor Author

You will ultimately change the test. Right?

Yes, the test was passing when the L0s for only this task were run, but failed when L0s for all tasks were run. I will fix it.

@tejasd1990 tejasd1990 merged commit 6609a7e into master Oct 22, 2019
tejasd1990 added a commit that referenced this pull request Oct 22, 2019
@tejasd1990
removing failing L0 test (#11617)
31b5a61 
* removing failing L0 test

* Update L0.ts
tejasd1990 added a commit that referenced this pull request Oct 22, 2019
@tejasd1990
removing failing L0 test (#11617)
ec11a01 
* removing failing L0 test

* Update L0.ts
tejasd1990 added a commit that referenced this pull request Oct 22, 2019
@tejasd1990
removing failing L0 test (#11617) (#11618)
235c8e8 
* removing failing L0 test

* Update L0.ts
tejasd1990 added a commit that referenced this pull request Oct 22, 2019
@tejasd1990
removing failing L0 test (#11617) (#11619)
5dfd28e 
* removing failing L0 test

* Update L0.ts
tejasd1990 added a commit that referenced this pull request Nov 8, 2019
@tejasd1990
removing failing L0 test (#11617)
19a7f45 
* removing failing L0 test

* Update L0.ts
tejasd1990 added a commit that referenced this pull request Nov 8, 2019
@tejasd1990
[M153.AzureDevOps2019.1.1]Users/tedeshpa/updating semver version for …
a4ea819 
…use dotnet v2 on m153.azure dev ops2019.1.1 (#11715)

* [resolving conflicts] handle preview versions

* removing failing L0 test (#11617)

* removing failing L0 test

* Update L0.ts

* [resolving conflicts]handling semver v2 versioning

* loc change

* loc change
@tejasd1990 tejasd1990 mentioned this pull request Nov 8, 2019
Merged
leantk pushed a commit that referenced this pull request Dec 23, 2019
@tejasd1990 @leantk
removing failing L0 test (#11617)
e531195 
* removing failing L0 test

* Update L0.ts
@starkmsu starkmsu deleted the uses/tedeshpa/UseDotNetV2RemoveFailingL0 branch July 14, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalajmsft jalajmsft jalajmsft approved these changes

@bishal-pdMSFT bishal-pdMSFT bishal-pdMSFT approved these changes

@hiyadav hiyadav Awaiting requested review from hiyadav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tejasd1990 @bishal-pdMSFT @jalajmsft