Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UseDotNetV2]handling semver v2 runtime preview versions #11610

Merged
merged 12 commits into from
Nov 7, 2019

Conversation

@hiyadav
Copy link
Contributor

hiyadav commented Oct 22, 2019

@tejasd1990 can you run some manual pipelines while downloading

  1. sdk
  2. runtime

of semver version 1.0 and 2.0

with

  1. exact versioning: 2.2.105
  2. 3.0.x / 3.x (with include preview enabled and disabled)

We just need to be sure that we aren't breaking anything here.

@tejasd1990
Copy link
Contributor Author

@hiyadav I have already tested various scenarios with the new change including versions which are v1 and v2

@tejasd1990 tejasd1990 changed the title updating semver version to ^6.3.0 to use semverv2 hanldeing semver v2 runtime preview versions Oct 22, 2019
@tejasd1990 tejasd1990 changed the title hanldeing semver v2 runtime preview versions [DotNetCoreCLIV2]handling semver v2 runtime preview versions Oct 25, 2019
@tejasd1990 tejasd1990 merged commit ff9ce7a into master Nov 7, 2019
tejasd1990 added a commit that referenced this pull request Nov 7, 2019
* updating semver version to ^6.3.0 to use semverv2

* hanlde v2 runtime preview versions

* Update models.ts

* review comment, some more fix

* formatting messages

* making semver version explicit
tejasd1990 added a commit that referenced this pull request Nov 7, 2019
…#11706)

* updating semver version to ^6.3.0 to use semverv2

* hanlde v2 runtime preview versions

* Update models.ts

* review comment, some more fix

* formatting messages

* making semver version explicit
@tejasd1990 tejasd1990 changed the title [DotNetCoreCLIV2]handling semver v2 runtime preview versions [UseDotNetV2]handling semver v2 runtime preview versions Nov 7, 2019
@TJEvans
Copy link

TJEvans commented Nov 14, 2019

This is a slight breaking change as the 'x' version identifier is now case sensitive....

@tejasd1990
Copy link
Contributor Author

Hi @TJEvans , The version identifier has always been case sensitive, it should be lower 'x'. Can you confirm whether it worked for you earlier with capital 'X' as well?

@TJEvans
Copy link

TJEvans commented Nov 15, 2019

Prior to the task updating this was the logs,
2019-11-07T17:23:44.3328779Z ##[section]Starting: Use dotnet sdk 2.2.X 2019-11-07T17:23:44.3759718Z ============================================================================== 2019-11-07T17:23:44.3759933Z Task : Use .NET Core 2019-11-07T17:23:44.3760075Z Description : Acquires a specific version of the .NET Core SDK from the internet or the local cache and adds it to the PATH. Use this task to change the version of .NET Core used in subsequent tasks. Additionally provides proxy support. 2019-11-07T17:23:44.3760386Z Version : 2.0.21 2019-11-07T17:23:44.3760508Z Author : Microsoft Corporation 2019-11-07T17:23:44.3760682Z Help : https://aka.ms/AA4xgy0 2019-11-07T17:23:44.3760780Z ============================================================================== 2019-11-07T17:23:45.3619447Z Tool to install: .NET Core sdk version 2.2.X. 2019-11-07T17:23:46.4170769Z Found version 2.2.402 in channel 2.2 for user specified version spec: 2.2.X 2019-11-07T17:23:46.4687151Z Version: 2.2.402 was found in cache. 2019-11-07T17:23:46.4736116Z Creating global tool path and pre-pending to PATH. 2019-11-07T17:23:46.4787149Z ##[section]Finishing: Use dotnet sdk 2.2.X

leantk pushed a commit that referenced this pull request Dec 23, 2019
* updating semver version to ^6.3.0 to use semverv2

* hanlde v2 runtime preview versions

* Update models.ts

* review comment, some more fix

* formatting messages

* making semver version explicit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants