Add commandline tests #11609
Add commandline tests #11609
Conversation
| @@ -2,6 +2,7 @@ | |||
| "name": "vsts-cmdline-task", | |||
| "dependencies": {}, | |||
| "globalDependencies": { | |||
| "mocha": "registry:dt/mocha#2.2.5+20160720003353", | |||
There was a problem hiding this comment.
We should get rid of typings and replace with @ types. Strangely I thought we already had everywhere.
There was a problem hiding this comment.
For some reason it really doesn't like me changing to @types, especially for node. Are you ok merging here and we can follow up on that later? There's also a fair amount of tasks that use typings - why is it a problem?
There was a problem hiding this comment.
Let's file an issue to do it so we can track.
Reason: Typings was deprecated a long time ago.
| @@ -18,6 +18,6 @@ | |||
| "homepage": "https://github.com/Microsoft/azure-pipelines-tasks#readme", | |||
| "dependencies": { | |||
| "uuid": "^3.0.1", | |||
| "azure-pipelines-task-lib": "2.7.0" | |||
| "azure-pipelines-task-lib": "2.7.1" | |||
There was a problem hiding this comment.
Is CI forcing a bump for changes?
There was a problem hiding this comment.
Whoops, meant to call out this change - mocking was briefly broken for v2.7.0 because it tried to reference vsts-task-lib (so I get a compile error), this was fixed in 2.7.1 - see this PR for reference - microsoft/azure-pipelines-task-lib#457
There was a problem hiding this comment.
LGTM - but let's see what @stephenmichaelf says about his comment.
No description provided.