Add bash tests #11595
Merged
Add bash tests #11595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linux/Mac tests are working now so this should be ready for review. |
|
Looks good, outside of general test cases are there any edge cases we want to add validation for? E.g. - if we had these tests would we have caught the last bug? |
|
Yeah, it would've. I think this currently tests every path except for a couple single argument cases (where a variable maps one to one with adding an argument to our execution of Bash). |
leantk
pushed a commit
that referenced
this pull request
Dec 23, 2019
* Add bash tests * Fix linux tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests inline/filepath cases + arg support.