fix: download x86 versions of Node.js #11560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykuzmin
changed the title
alexeykuzmin
commented
Oct 14, 2019
Tasks/UseNodeV1/installer.ts
Outdated
| 'node-v' + version + '-' + osPlat + '-' + os.arch(); | ||
| let urlFileName: string = osPlat == 'win32'? fileName + '.7z': | ||
| fileName + '.tar.gz'; | ||
| const arch = (osArch === 'ia32') ? 'x86' : osArch; |
There was a problem hiding this comment.
The actual fix.
Everything else is a clean-up.
damccorm
reviewed
Oct 15, 2019
| let exeUrl: string; | ||
| let libUrl: string; | ||
| try { | ||
| exeUrl = `https://nodejs.org/dist/v${version}/win-${os.arch()}/node.exe`; | ||
| libUrl = `https://nodejs.org/dist/v${version}/win-${os.arch()}/node.lib`; | ||
| exeUrl = `https://nodejs.org/dist/v${version}/win-${osArch}/node.exe`; |
There was a problem hiding this comment.
Actually, maybe just move the change up to where we define osArch in line 8? That way it propogates to error messages too. So it could be
const arch = os.arch();
const osArch = (arch === 'ia32') ? 'x86' : arch;
There was a problem hiding this comment.
You're right, 'x86' should be used in all cases here. Done.
|
Could you update this file's task.json version and task.loc.json? Should be version |
Node.js uses "x86" and not "ia32" as an os arch identifier in download URLs.
leantk
pushed a commit
that referenced
this pull request
Dec 23, 2019
Node.js uses "x86" and not "ia32" as an os arch identifier in download URLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js uses "x86" and not "ia32" as an os arch identifier in download URLs.
Check here: