ARMTemplateDeployTask: Commented out an L0 #11412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalajmsft
approved these changes
Sep 24, 2019
vinodkumar3
added a commit
that referenced
this pull request
Sep 24, 2019
vinodkumar3
added a commit
that referenced
this pull request
Sep 24, 2019
* Implemented ARM Deployment task (#11404) * Armtask (#11331) * Implemented ARMTemplateDeployment task * Implemented ARMTemplateDeployment task * Implemented ARMTemplateDeployment task3 * Implemented ARMTemplateDeployment task4 * Added support for Management group and Subscription level deployment scope (#11265) * Implemented AzureServiceClientBase &DeploymentBase * Added validations * Updated properties of base classes * Modified patch version of related tasks * Revert "Modified patch version of related tasks" This reverts commit 8e01c19. * Modified patch version of related tasks * Updated existing tests * Addressed review comments * Implemented ARMTemplateDeployment task5 * Revert "Added support for Management group and Subscription level deployment scope (#11265)" This reverts commit 06f0b29. * Update AzureResourceManagerTemplateDeployment task's description Co-Authored-By: Bishal Prasad <[email protected]> * Updated Task's description Co-Authored-By: Bishal Prasad <[email protected]> * Updated README, task,json and addressed review comments (#11402) * Implemented ARMTemplateDeployment task * Implemented ARMTemplateDeployment task * Implemented ARMTemplateDeployment task3 * Implemented ARMTemplateDeployment task4 * Added support for Management group and Subscription level deployment scope (#11265) * Implemented AzureServiceClientBase &DeploymentBase * Added validations * Updated properties of base classes * Modified patch version of related tasks * Revert "Modified patch version of related tasks" This reverts commit 8e01c19. * Modified patch version of related tasks * Updated existing tests * Addressed review comments * Implemented ARMTemplateDeployment task5 * Revert "Added support for Management group and Subscription level deployment scope (#11265)" This reverts commit 06f0b29. * Addressed review comments * Updated L0 tests & addressed review comments * update readme * Updated help text * Deleted unused files * Addressed review comments * Commented out an L0 (#11412)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its breaking on merging with master - https://dev.azure.com/mseng/PipelineTools/_build/results?buildId=10491554&view=results
However working fine with PR automated build - https://dev.azure.com/mseng/PipelineTools/_build/results?buildId=10491532&view=results