Docker task changes to push additional data as per image provenance A… #11409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vithati
approved these changes
Sep 25, 2019
| const jobName = addPipelineData ? tl.getVariable("System.PhaseDisplayName") : ""; | ||
| const creator = addPipelineData ? dockerCommandUtils.getCreatorEmail() : ""; | ||
| const logsUri = addPipelineData ? dockerCommandUtils.getPipelineLogsUrl() : ""; | ||
| const artifactStorageSourceUri = addPipelineData ? dockerCommandUtils.getPipelineUrl() : ""; |
There was a problem hiding this comment.
is it builddefinition ulr or build url?
There was a problem hiding this comment.
artifactStorageSourceUri is a part of source provenance, hence it corresponds to the definition url, which is the source of this build/run
dabasnidhi
force-pushed
the
users/nidabas/dockerV2Update
branch
from
2b9db22 to
7719cfd
Compare
dabasnidhi
requested review from
navin22 and
SadagopanRajaram
as code owners
vithati
approved these changes
Sep 26, 2019
| } | ||
|
|
||
| export async function getImageRootfsLayers(connection: ContainerConnection, imageDigest: string): Promise<string[]> { | ||
| var command = connection.createCommand(); |
There was a problem hiding this comment.
check imageDigest empty and return;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…PI spec