Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addresses #11246 #11361

Merged
merged 2 commits into from
Sep 17, 2019
Merged

addresses #11246 #11361

merged 2 commits into from
Sep 17, 2019

Conversation

moswald
Copy link
Member

@moswald moswald commented Sep 17, 2019

We should be setting the current working directory before we do things like check the existence of files.

gulpFile parameter has a default, so it shouldn't be considered required.

@moswald moswald requested a review from hross as a code owner September 17, 2019 19:16
@moswald moswald merged commit 2cf5aae into master Sep 17, 2019
@moswald moswald mentioned this pull request Sep 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmichaelf stephenmichaelf stephenmichaelf approved these changes

@hross hross Awaiting requested review from hross

@davidstaheli davidstaheli Awaiting requested review from davidstaheli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moswald @stephenmichaelf