Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing mergeTestResutls as false for the VsTest task. #11352

Merged
merged 2 commits into from
Sep 17, 2019

Conversation

navin22
Copy link
Member

@navin22 navin22 commented Sep 17, 2019

Default value of mergeTestResults is True and this actually archives the attachments as well.
Which causes the code coverage jobs to fail, as they will be looking for the .coverage files.
We actually pass the mergeTestResutls as false in VsTestV2 also, it was a miss from my side in previous change.

@navin22 navin22 requested review from kaadhina and nigurr September 17, 2019 06:40
@navin22 navin22 requested a review from cltshivash as a code owner September 17, 2019 06:40
@nigurr
Copy link

nigurr commented Sep 17, 2019

I am assuming we have an L2 to catch this regression, going forward

@navin22
Copy link
Member Author

navin22 commented Sep 17, 2019

I am assuming we have an L2 to catch this regression, going forward

Sure, since we now have this scenario. Will try to do similar L2 like V2 tasks.

@navin22 navin22 closed this Sep 17, 2019
@navin22 navin22 reopened this Sep 17, 2019
@navin22 navin22 merged commit c8f4247 into microsoft:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants