Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added wait for service external Ip assignment #11325

Merged
merged 14 commits into from
Sep 18, 2019

Conversation

anuragc617
Copy link
Contributor

No description provided.

Copy link
Contributor

@thesattiraju thesattiraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests.

@anuragc617 anuragc617 merged commit e9932f6 into master Sep 18, 2019
anuragc617 added a commit that referenced this pull request Sep 23, 2019
* service wait for ip

* updated task.json

* code refactoring

* addressed review comments

* addressing review comments

* some more review comments

* added test for service IP
anuragc617 added a commit that referenced this pull request Sep 23, 2019
* service wait for ip

* updated task.json

* code refactoring

* addressed review comments

* addressing review comments

* some more review comments

* added test for service IP
Copy link

@Olivacity Olivacity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want it to be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants