[Gradle Task] JaCoCo compatible with gradle 5.x

[mickael-caro-sonarsource]

No description provided.

[madhurig]

Overall looks good to me. Is there any issue with compatibility of the latest jacoco version with older versions of gradle?

[madhurig]

@mickael-caro-sonarsource - thank you for your contribution ✨!

[mickael-caro-sonarsource]

Thanks for the review. Given this changelog : https://www.jacoco.org/jacoco/trunk/doc/changes.html No depreciations are mentionned, so it should be ok. I will bump the versions correctly now.

[mickael-caro-sonarsource]

@madhurig after checking the documentation, some Gradle versions might not work anymore with this change. Which versions are you officially supporting within those tasks ? Thanks.

[pjquirk]

after checking the documentation, some Gradle versions might not work anymore with this change. Which versions are you officially supporting within those tasks ? Thanks.

@mickael-caro-sonarsource I don't see any documentation for officially supported versions, unfortunately (looking here). What incompatibilities are you seeing, and which versions may not work because of them? I went back as far as Gradle 3.0 (released Aug 2016) and saw the file() method still available.

[mickael-caro-sonarsource]

I have a doubt, considering this chapter, on which the syntax is the current one : https://docs.gradle.org/3.0/userguide/jacoco_plugin.html#sec:jacoco_report_configuration

[pjquirk]

It looks like the $ is being escaped here, so the end result would be path/to/build.gradle/${buildDir}/jacocoHtml, rather than replacing ${buildDir} with it's value. Or am I missing something?

[mickael-caro-sonarsource]

This is intended to be replace in the build.gradle file instead, as a project property.

[pjquirk]

Oh I see now, phew that's confusing

[pjquirk]

That is just Groovy syntax, $var or ${var} both work.

[pjquirk]

Thanks @mickael-caro-sonarsource!

[adriaanthomas]

This would also help the MavenV3 task, as JaCoCo coverage doesn't currently work with Java 11 code there. Is there any idea when this will be released?