Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Condition Corrected #11226

Merged
merged 4 commits into from
Aug 27, 2019
Merged

Failing Condition Corrected #11226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c3c13d
Condition Corrected
eaarora-ms Aug 27, 2019
3240e0e
Merge branch 'master' into ErrorFIxAppSettings
eaarora-ms Aug 27, 2019
67530e7
Readme updated
eaarora-ms Aug 27, 2019
b16e0ac
Merge branch 'ErrorFIxAppSettings' of https://github.com/eaarora-ms/a…
eaarora-ms Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tasks/AzureAppServiceSettingsV1/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ The task is used to deploy a Web project to an existing Azure Web App or Functi
[Configure an App Service app](https://docs.microsoft.com/en-us/azure/app-service/configure-common)

**App settings**: [App settings](https://docs.microsoft.com/en-us/azure/app-service/web-sites-configure#app-settings) contains name/value pairs that your web app will load on start up. Edit web app application settings by following the syntax :
>Example :
>Example:
[
{
"name": "key1",
Expand Down
2 changes: 1 addition & 1 deletion Tasks/AzureAppServiceSettingsV1/azurewebappsettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ async function main() {
var ConfigurationSettings: string = tl.getInput('generalSettings', false);
var ConnectionStrings: string = tl.getInput('connectionStrings', false);

if(!AppSettings || !ConfigurationSettings || !ConnectionStrings) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

increment patch

if(!AppSettings && !ConfigurationSettings && !ConnectionStrings) {
throw Error(tl.loc("AppServiceSettingsNotEnabled"));
}

Expand Down