Users/suaggar/warcustomname #11181
Merged
Users/suaggar/warcustomname #11181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SumiranAgg
added
Area: Release
Area: AzureAppService
vincent1173
approved these changes
Aug 22, 2019
Tasks/AzureWebAppV1/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
| @@ -18,6 +18,8 @@ | |||
| "loc.input.help.slotName": "Enter or Select an existing Slot other than the Production slot.", | |||
| "loc.input.label.package": "Package or folder", | |||
| "loc.input.help.package": "File path to the package or a folder containing app service contents generated by MSBuild or a compressed zip or war file.<br />Variables ( [Build](https://docs.microsoft.com/vsts/pipelines/build/variables) | [Release](https://docs.microsoft.com/vsts/pipelines/release/variables#default-variables)), wildcards are supported. <br/> For example, $(System.DefaultWorkingDirectory)/\\*\\*/\\*.zip or $(System.DefaultWorkingDirectory)/\\*\\*/\\*.war.", | |||
| "loc.input.label.customWarName": "Custom war name", | |||
There was a problem hiding this comment.
I don't think function app takes WAR package. Can you please verify it once?
| @@ -45,7 +45,7 @@ export class BuiltInLinuxWebAppDeploymentProvider extends AzureRmWebAppDeploymen | |||
|
|
|||
| case PackageType.war: | |||
| tl.debug("Initiated deployment via kudu service for webapp war package : "+ this.taskParams.Package.getPath()); | |||
| let warName = webCommonUtility.getFileNameFromPath(this.taskParams.Package.getPath(), ".war"); | |||
| let warName = this.taskParams.CustomWarName || webCommonUtility.getFileNameFromPath(this.taskParams.Package.getPath(), ".war"); | |||
There was a problem hiding this comment.
can we print this value in debug logs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.