Updated to print out number of archived files #7465 #11175
Conversation
jtpetty
commented
Aug 21, 2019
jtpetty
commented
- Number is capped to a small number to prevent spamming the console
- Added initial L0 test suite for ArchiveFiles
- Number is capped to a small number to prevent spamming the console - Added initial L0 test suite for ArchiveFiles
Tasks/ArchiveFilesV2/Tests/L0.ts
Outdated
|
|
||
| tl.setResourcePath(path.join( __dirname, '..', 'task.json')); | ||
| cases.forEach(function(numberOfFiles) { | ||
| it('plan for ' + numberOfFiles + ' files', (done: MochaDone) => { |
There was a problem hiding this comment.
Can we make the description more informative? Hard to deduce from the description what this is testing.
|
Can we add a screenshot here of what the output looks like? |
|
Need to update minor version in task.json and task.loc.json. |
| console.log(line); | ||
| }); | ||
|
|
||
| tl.debug('Listing all ' + files.length + ' files to archive:'); | ||
| for (var i = 0; i < files.length; i++) { |
There was a problem hiding this comment.
If we are already iterating and debugging the files here can we combine the two into this one method and just check if we are below the max number of files we want to always print and console.log? Then print the "more files" message if files.length > maxNumberOfLinesToLog?
Then the iterating and printing is all together.
There was a problem hiding this comment.
yeah, i probably over complicated it by trying to encapsulate the output into a testable method and did not want to inadvertently mess up the debug output
There was a problem hiding this comment.
I think we can keep it as its own method, just change the plan.push calls to console.log statements
There was a problem hiding this comment.
I am not sure I understand what you are suggesting
There was a problem hiding this comment.
Oh nevermind. I was suggesting pushing the logging into the function and not returning an object, realize now that we lose the testability with that approach. I'm fine with it as is.
|
|
Tasks/ArchiveFilesV2/task.json
Outdated
| @@ -18,8 +18,8 @@ | |||
| "demands": [], | |||
| "version": { | |||
| "Major": 2, | |||
| "Minor": 151, | |||
| "Patch": 2 | |||
| "Minor": 152, | |||
There was a problem hiding this comment.
The convention that people use is to make it the number of the sprint the change is made it. I am not sure I entirely agree but that's how it's done :)
| console.log(line); | ||
| }); | ||
|
|
||
| tl.debug('Listing all ' + files.length + ' files to archive:'); | ||
| for (var i = 0; i < files.length; i++) { |
There was a problem hiding this comment.
I think we can keep it as its own method, just change the plan.push calls to console.log statements
