fix for slots #1117
fix for slots #1117
Conversation
| @@ -31,7 +31,7 @@ | |||
| { | |||
| "name": "WebSiteName", | |||
| "type": "pickList", | |||
| "label": "Web App Name", | |||
| "label": "Web App Name with out slot.If your web app uses slot, mention in **Slot** field, else default **Production** slot is considered", | |||
There was a problem hiding this comment.
Grammar/verbiage:
Web App Name. If your web app uses a slot, use the **Slot** field. Otherwise the default **Production** slot is used.
It looks like the web app name is always required. It's not: web app name XOR slot. So I think "Web App Name without a slot" should just be "Web App Name". Otherwise you're implying it's either or.
There was a problem hiding this comment.
Actually. No..it is required. Websitenames with slot would have.. test(slot), I was suggesting instead of that...have websitename as just 'test' and put the slot in slot field.
yaananth
force-pushed
the
users/yaananth/fixes/azureSlot
branch
from
69e7b22 to
a6aec19
Compare
|
The verbiage change is confusing. Assuming you fix that, change looks good. |
| Write-Host "Get-AzureWebSite -Name $WebSiteName -ErrorAction SilentlyContinue -ErrorVariable azureWebSiteError" | ||
| $azureWebSite = Get-AzureWebSite -Name $WebSiteName -ErrorAction SilentlyContinue -ErrorVariable azureWebSiteError | ||
| #Default slot to production so that we can get back single website with more details | ||
| $Slot = "Production" |
There was a problem hiding this comment.
I'm guessing we don't need to worry about this needing to be localized?
yaananth
force-pushed
the
users/yaananth/fixes/azureSlot
branch
from
a6aec19 to
577e214
Compare
|
Updated, I will test thins, if code and everything looks good.then will update M94 PR |
| $streamReader.Close() | ||
| Write-Warning "Cannot update deployment status for $WebSiteName - $responseBody" | ||
| if($matchedNames -and $matchedNames.count -gt 0) { | ||
| $WebSiteName = $matchedNames[0] |
There was a problem hiding this comment.
$matchedWebSiteName = $azureWebSite.EnabledHostNames | Where-Object { $_ -like 'some wildcard pattern' } | Select-Object -First 1
if ($matchedWebSiteName) {
[...]
yaananth
force-pushed
the
users/yaananth/fixes/azureSlot
branch
from
577e214 to
12ccc5a
Compare
|
Looks good. |
fix for slots ( into master )
No description provided.