Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to GitHubReleaseTask #11166

Merged
merged 11 commits into from
Aug 22, 2019
Merged

Minor improvements to GitHubReleaseTask #11166

merged 11 commits into from
Aug 22, 2019

Conversation

TheLayman
Copy link
Contributor

  • Updated "NoTagFound" warning message
  • Updated help text for "tagPattern" input
  • setting default ChangeLogType to commitBased
  • If the only category is "Others", Emit the category and simply show the flat list of issues.

@TheLayman TheLayman requested a review from prativen August 21, 2019 07:13
prativen
prativen reviewed Aug 21, 2019
View reviewed changes
Copy link
Member

@prativen prativen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. do we need to bump up the version? can we keep minor at 0?

  2. UTs?

Tasks/GitHubReleaseV0/operations/ChangeLog.ts Show resolved Hide resolved
@TheLayman
Copy link
Contributor Author

@prativen If the code is checked-in this sprint itself don't need to bump the minor/patch.
Increasing the patch is followed to ensure that the changes are deployed.

@TheLayman TheLayman merged commit 69cf721 into master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prativen prativen prativen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheLayman @prativen