Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UniversalPackagesV0: Update help text for wildcard versioning #11140

Merged
merged 1 commit into from
Aug 20, 2019
Merged

UniversalPackagesV0: Update help text for wildcard versioning #11140

merged 1 commit into from
Aug 20, 2019

Conversation

zarenner
Copy link
Contributor

No description provided.

@zarenner zarenner requested a review from elbatk August 17, 2019 00:02
@zarenner zarenner requested a review from zjrunner as a code owner August 17, 2019 00:02
@zarenner
Copy link
Contributor Author

Hold merging until feature is released

@shubham90
Copy link
Member

Hold merging until feature is released

You'll need to bump the task version for this change to actually deploy. May be to 0.157.0

zjrunner
zjrunner approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@zjrunner zjrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to bump version too, or already bumped and waiting for release?

b-barthel
b-barthel approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@b-barthel b-barthel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to bump the task version to get this picked up?

@zarenner zarenner force-pushed the users/zarenner/wildcardHelpText branch from 670157b to be59ee0 Compare August 19, 2019 23:14
@zarenner
Copy link
Contributor Author

Gah, thanks all 3 of you. Bumped version.

@zarenner zarenner merged commit 8e819aa into master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-barthel b-barthel b-barthel approved these changes

@shubham90 shubham90 shubham90 approved these changes

@zjrunner zjrunner zjrunner approved these changes

@elbatk elbatk Awaiting requested review from elbatk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zarenner @shubham90 @zjrunner @b-barthel