Fix selecting incorrect latest version of Node #11116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rubber stamp LGTM. Looked over the code and tests and this looks good - thank you for PRing Anthony! |
|
This generally looks good to me - could you bump the version in the task.json/task.loc.json files for both tasks? |
|
Whoops I missed this earlier. Bumped versions. Hopefully this is still relevant. |
leantk
pushed a commit
that referenced
this pull request
Dec 23, 2019
* Ignore 'v' prefix when evaluating latest in UseNodeV1 * Ignore 'v' prefix when evaluating latest in NodeToolV0 * Bump versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's a bug when selecting a node version. The task passes an array of available node versions to
toolLib.evaluateVersions()that are prefixed withv(e.g.v12.8.0). This messes up the sorting inside the method, causing it to select the wrong version.This is particularly noticeable when using a version spec of
>=0.0.0or*(both meaning select the absolute latest). It currently select6.17.1instead of the correct latest version of12.8.0.Changing the task so that it passes valid semantic versions (without
v) totoolLib.evaluateVersions(), and returns the selected version with the leadingv.Fixing both V0 and V1.
/cc @sinedied @bnb