Fix #10888 DotNetCoreCLIV2 pack search pattern help text #10889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
|
hiyadav
approved these changes
Jul 17, 2019
|
@ryanriv I hope you don't mind I merged in master and added changes to bump the task version (required for the service to pick up the changes) |
jmyersmsft
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the help text seemed to be inaccurate (#10888). This PR changes the negative pattern example from '-:' to '!', which worked for me when I was testing. This took me a while to figure out, so I hope this helps someone else :)
Please let me know if I missed anything or if any other changes are needed.