[KubernetesManifest] Check manifest stability for Pods #10684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishubansal
reviewed
Jun 24, 2019
nishubansal
reviewed
Jun 24, 2019
nishubansal
reviewed
Jun 24, 2019
nishubansal
requested changes
Jun 24, 2019
…-tasks into users/desattir/stabilityDetectionForPod
nishubansal
approved these changes
Jun 24, 2019
vithati
reviewed
Jun 24, 2019
| const timeOut = 5 * 60 * 1000; // Timeout 5 min | ||
| let currentTime = new Date(); | ||
| let podStatus; | ||
| while (currentTime.getTime() - startTime.getTime() < timeOut) { |
There was a problem hiding this comment.
This is busy loop. Can you add sleep and Instead of time use Iteration.
| @@ -66,5 +66,7 @@ | |||
| "loc.messages.NullInputObjectMetadata": "Input object metadata is null.", | |||
| "loc.messages.CanaryDeploymentAlreadyExistErrorMessage": "Canary deployment already exists. Rejecting this deployment.", | |||
| "loc.messages.InvalidRejectActionDeploymentStrategy": "Reject action works only with strategy: canary", | |||
| "loc.messages.InvalidPromotetActionDeploymentStrategy": "Promote action works only with strategy: canary" | |||
| "loc.messages.InvalidPromotetActionDeploymentStrategy": "Promote action works only with strategy: canary", | |||
There was a problem hiding this comment.
End with '.'. Add for below messages.
| while (currentTime.getTime() - startTime.getTime() < timeOut) { | ||
| tl.debug(`Polling for pod status: ${podName}`); | ||
| podStatus = getPodStatus(kubectl, podName); | ||
| if (podStatus.phase && podStatus.phase !== 'Pending') { |
There was a problem hiding this comment.
In case of 'Unknown' status do you want to retry?
vithati
reviewed
Jun 24, 2019
| @@ -14,7 +14,7 @@ | |||
| "version": { | |||
| "Major": 0, | |||
| "Minor": 154, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the capability to check if a pod is in a ready state to the KubernetesManifest task.