Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KubernetesManifestV0: Updating from [email protected] to azure-pip… #10650

Merged
merged 1 commit into from
Jun 13, 2019
Merged

KubernetesManifestV0: Updating from [email protected] to azure-pip… #10650

merged 1 commit into from
Jun 13, 2019

Conversation

savenkat
Copy link
Member

…[email protected]

  • Also moved KubernetesManifestV0
    • from 'kubernetes-common' to 'kubernetes-common-v2'
    • from 'docker-common' to 'docker-common-v2'
  • Removed dependency on 'utility-common' as it was unused.
  • Bumped up patch version

@savenkat savenkat requested a review from bansalaseem as a code owner June 13, 2019 10:26
@savenkat savenkat requested review from thesattiraju and Anumita June 13, 2019 10:26
@savenkat
KubernetesManifestV0: Updating from [email protected] to azure-pip…
4ef5ed9 
…[email protected]

- Also moved KubernetesManifestV0
	- from 'kubernetes-common' to 'kubernetes-common-v2'
	- from 'docker-common' to 'docker-common-v2'
- Removed dependency on 'utility-common' as it was unused.
- Bumped up patch version
@savenkat savenkat force-pushed the users/savenkat/kubeManifestV0Up branch from d9bcaf8 to 4ef5ed9 Compare June 13, 2019 10:32
@savenkat savenkat requested a review from vithati June 13, 2019 11:09
@savenkat savenkat merged commit e739a91 into master Jun 13, 2019
thesattiraju
thesattiraju reviewed Jun 13, 2019
View reviewed changes
Tasks/KubernetesManifestV0/ThirdPartyNotices.txt
@@ -1621,7 +1621,7 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

=========================================
END OF VSTS-Task-Lib NOTICES, INFORMATION, AND LICENSE
END OF Azure-Pipelines-Task-Lib NOTICES, INFORMATION, AND LICENSE

%% wrappy NOTICES, INFORMATION, AND LICENSE BEGIN HERE
=========================================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the TPN file needs to be updated, as utility-common dependency is removed, could you check if there are references of modules here in the TPN, but not in the task?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesattiraju thesattiraju thesattiraju left review comments

@vithati vithati vithati approved these changes

@bansalaseem bansalaseem Awaiting requested review from bansalaseem

@Anumita Anumita Awaiting requested review from Anumita

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@savenkat @vithati @thesattiraju