Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HelmInstallerV1: Updating azure-pipelines-task-lib from v2.7.7 to v2.8.0 #10639

Merged
merged 2 commits into from
Jun 13, 2019

Conversation

savenkat
Copy link
Member

  • Also moved HelmInstallerV1 from using 'kubernetes-common' to 'kubernetes-common-v2'
  • Bumped up patch version

- Also moved HelmInstallerV1 from using 'kubernetes-common' to 'kubernetes-common-v2'
- Bumped up patch version
@savenkat savenkat requested review from Anumita and thesattiraju June 12, 2019 06:28
@savenkat savenkat requested a review from bansalaseem as a code owner June 12, 2019 06:28
@@ -10,7 +10,8 @@
"rm": [
{
"items": [
"node_modules/kubernetes-common/node_modules/vsts-task-lib"
"node_modules/kubernetes-common/node_modules/vsts-task-lib",
"node_modules/kubernetes-common-v2/node_modules/azure-pipelines-task-lib"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first one won't be needed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but I kept it there so that ppl building this would clear off their old dependencies as well.

@savenkat savenkat merged commit 9f6762b into master Jun 13, 2019
@savenkat savenkat deleted the users/savenkat/helmInstallerV1Up branch June 13, 2019 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants