Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Docker task issues - Dockerfile in push command, and lowercasing of image names. #10506

Merged
merged 5 commits into from
May 30, 2019
Merged

Fixing Docker task issues - Dockerfile in push command, and lowercasing of image names. #10506

merged 5 commits into from
May 30, 2019

Conversation

ajinkya599
Copy link
Contributor

@ajinkya599 ajinkya599 commented May 28, 2019 •
edited
Loading

Fixing two Docker task issues important for on-prem release:

  • Docker push should not depend on Dockerfile. Determine base image name from Dockerfile if the command is buildAndPush, else set it as NA. We will be working on finding a way to determine the base image name, so that we can do it for docker push as well. This fix is to unblock the docker push command. (issue Docker push requires Dockerfile #10148)
  • Use Docker naming conventions for image names, i.e., change to lowercase and remove spaces. (issue Docker@2 respository name broke with uppercase #10415)

@ajinkya599 ajinkya599 requested a review from bansalaseem May 28, 2019 17:48
@ajinkya599 ajinkya599 requested review from jikuma and vithati as code owners May 28, 2019 17:48
@ajinkya599 ajinkya599 force-pushed the users/aj/dockerTaskIssues branch from 2cd5578 to e9d9885 Compare May 30, 2019 08:19
@ajinkya599 ajinkya599 removed the request for review from jikuma May 30, 2019 08:20
dabasnidhi
dabasnidhi approved these changes May 30, 2019
View reviewed changes
Tasks/DockerV2/dockerpush.ts Show resolved Hide resolved
@ajinkya599 ajinkya599 force-pushed the users/aj/dockerTaskIssues branch from 55b14af to 2d46c4d Compare May 30, 2019 09:48
@ajinkya599 ajinkya599 merged commit 7dceff4 into master May 30, 2019
ajinkya599 added a commit that referenced this pull request Jun 12, 2019
@ajinkya599
[Port to m153]: Fixing Docker task issues - Dockerfile in push comman…
92cc220 
…d, and lowercasing of image names. (#10506)

* Fixing Docker task issues - Dockerfile in push command, and lowercasing of image names.

* Use NA as baseImageName in case of only push command. Minor change in debug logs.

* Bumping up task versions

* change as suggested in PR review comment
ajinkya599 added a commit that referenced this pull request Jun 17, 2019
@ajinkya599
[Port to m153]: Fixing Docker task issues - Dockerfile in push comman…
09f270a 
…d, and lowercasing of image names. (#10506)

* Fixing Docker task issues - Dockerfile in push command, and lowercasing of image names.

* Use NA as baseImageName in case of only push command. Minor change in debug logs.

* Bumping up task versions

* change as suggested in PR review comment
ajinkya599 added a commit that referenced this pull request Jun 17, 2019
@ajinkya599
[Port to m153]: Fixing Docker task issues - Dockerfile in push comman…
2d4aa0a 
…d, and lowercasing of image names. (#10506) (#10645)

* [Port to m153]: Fixing Docker task issues - Dockerfile in push command, and lowercasing of image names. (#10506)

* Fixing Docker task issues - Dockerfile in push command, and lowercasing of image names.

* Use NA as baseImageName in case of only push command. Minor change in debug logs.

* Bumping up task versions

* change as suggested in PR review comment

* rebasing with releases/m153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vithati vithati vithati approved these changes

@dhashrath-msft dhashrath-msft dhashrath-msft approved these changes

@dabasnidhi dabasnidhi dabasnidhi approved these changes

@bansalaseem bansalaseem Awaiting requested review from bansalaseem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajinkya599 @dabasnidhi @dhashrath-msft @vithati