Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This updates the filter rules for ARM connections in task inputs #10315

Merged
merged 2 commits into from
May 14, 2019

Conversation

romil07
Copy link
Contributor

@romil07 romil07 commented May 6, 2019

No description provided.

@romil07 romil07 force-pushed the users/rogoyal/FiltersOnScopeLevel branch from 211c882 to e7e95bd Compare May 6, 2019 07:54
Copy link

@Ajay-MS Ajay-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the default filtering rule at Connected Service Component and ARM Service Component Utility. Otherwise all task will list down AzureMLWorkspace based endpoints too.

@romil07 romil07 merged commit 1b2a773 into master May 14, 2019
@romil07 romil07 deleted the users/rogoyal/FiltersOnScopeLevel branch May 14, 2019 06:27
@@ -72,7 +72,7 @@
"helpMarkDown": "Azure Resource Manager subscription to configure before running PowerShell",
"visibleRule": "ConnectedServiceNameSelector = ConnectedServiceNameARM",
"properties": {
"EndpointFilterRule": "ScopeLevel == ManagementGroup || ScopeLevel != ManagementGroup"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't quite get what this means? This will always be true.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmkumaran @asranja IIRC, this condition will always be true.

@@ -72,7 +72,7 @@
"helpMarkDown": "Azure Resource Manager subscription to configure before running PowerShell",
"visibleRule": "ConnectedServiceNameSelector = ConnectedServiceNameARM",
"properties": {
"EndpointFilterRule": "ScopeLevel == ManagementGroup || ScopeLevel != ManagementGroup"
"EndpointFilterRule": "ScopeLevel != AzureMLWorkspace"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants